blender
/
blender
137
411
Fork 594
Code Issues 6.3k Pull Requests 770 Projects 19 Wiki Activity

Geometry Nodes: Operator to wrap a modifier's node group #104546

Merged
Hans Goudey merged 19 commits from HooglyBoogly/blender:geometry-nodes-wrapper-operator into main 2023-02-14 18:22:04 +01:00
Conversation 0 Commits 19 Files Changed 2 +4 -4
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 78b2ff20cf - Show all commits

6
release/scripts/startup/bl_operators/geometry_nodes.py
View File

@ -97,10 +97,10 @@ def get_enabled_socket_with_name(sockets, name):
return None
HooglyBoogly marked this conversation as resolved
Jacques Lucke commented 2023-02-10 20:40:42 +01:00
Review
Copy Link

The name is still kind of ugly. Maybe something like Move to Nodes (description: Move inputs and outputs set in the modifier to a new node group) or what Simon suggested.

The name is still kind of ugly. Maybe something like `Move to Nodes` (description: `Move inputs and outputs set in the modifier to a new node group`) or what Simon suggested.
Hans Goudey commented 2023-02-13 18:05:09 +01:00
Review
Copy Link

Yeah, good idea!

Yeah, good idea!
class CreateModifierWrapperGroup(Operator):
class MoveModifierToNodes(Operator):
"""Move inputs and outputs from in the modifier to a new node group"""
HooglyBoogly marked this conversation as resolved
Jacques Lucke commented 2023-02-14 13:46:34 +01:00
Review
Copy Link

The class name and idname should be updated to respect the new label.

The class name and idname should be updated to respect the new label.
bl_idname = "object.new_geometry_node_group_wrapper"
bl_idname = "object.geometry_nodes_move_to_nodes"
bl_label = "Move to Nodes"
bl_options = {'REGISTER', 'UNDO'}
@ -239,5 +239,5 @@ class NewGeometryNodeTreeAssign(Operator):
classes = (
NewGeometryNodesModifier,
NewGeometryNodeTreeAssign,
CreateModifierWrapperGroup,
MoveModifierToNodes,
)

2
source/blender/modifiers/intern/MOD_ui_common.c
View File

@ -277,7 +277,7 @@ static void modifier_ops_extra_draw(bContext *C, uiLayout *layout, void *md_v)
if (md->type == eModifierType_Nodes) {
uiItemFullO(layout,
"OBJECT_OT_new_geometry_node_group_wrapper",
"OBJECT_OT_geometry_nodes_move_to_nodes",
NULL,
ICON_NONE,
NULL,