blender
/
blender
136
406
Fork 589
Code Issues 6.3k Pull Requests 766 Projects 19 Wiki Activity

VSE: Add sound strip retiming support #105072

Merged
Richard Antalik merged 16 commits from iss/blender:retiming-sound-2 into main 2023-04-21 16:53:39 +02:00
Conversation 10 Commits 16 Files Changed 14 +3 -3
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 2c03048513 - Show all commits

6
source/blender/sequencer/intern/strip_retiming.cc
View File

@ -284,7 +284,7 @@ class RetimingRange {
class RetimingRangeData {
public:
std::vector<RetimingRange> ranges;
iss marked this conversation as resolved Outdated
Sergey Sharybin commented 2023-04-18 09:57:44 +02:00
Outdated
Review
Copy Link

Any specific reason to use std::vector instead of blender::Vector?
Unless there is really goo reason (like, interfacing with an external library) we'd better be consistently using our own primitives.

Any specific reason to use `std::vector` instead of `blender::Vector`? Unless there is really goo reason (like, interfacing with an external library) we'd better be consistently using our own primitives.
RetimingRangeData(const Scene *scene, const Sequence *seq)
RetimingRangeData(const Sequence *seq)
{
MutableSpan handles = SEQ_retiming_handles_get(seq);
for (const SeqRetimingHandle &handle : handles) {
@ -350,14 +350,14 @@ class RetimingRangeData {
static RetimingRangeData seq_retiming_range_data_get(const Scene *scene, const Sequence *seq)
{
RetimingRangeData strip_retiming_data = RetimingRangeData(scene, seq);
RetimingRangeData strip_retiming_data = RetimingRangeData(seq);
const Sequence *meta_parent = seq_sequence_lookup_meta_by_seq(scene, seq);
if (meta_parent == nullptr) {
return strip_retiming_data;
}
RetimingRangeData meta_retiming_data = RetimingRangeData(scene, meta_parent);
RetimingRangeData meta_retiming_data = RetimingRangeData(meta_parent);
strip_retiming_data *= meta_retiming_data;
return strip_retiming_data;
}