VSE: Add sound strip retiming support #105072

Merged
Richard Antalik merged 16 commits from iss/blender:retiming-sound-2 into main 2023-04-21 16:53:39 +02:00

16 Commits

Author SHA1 Message Date
Richard Antalik 908cb5cc25 Merge branch 'main' into retiming-sound-2
buildbot/vexp-code-patch-coordinator Build done. Details
2023-04-21 16:29:17 +02:00
Richard Antalik 89512d7128 Fix sound strip length not changing
buildbot/vexp-code-patch-coordinator Build done. Details
2023-04-19 18:29:46 +02:00
Richard Antalik b92d912f59 Fix mistake in last commit 2023-04-19 16:30:54 +02:00
Richard Antalik e696b2f86d Address feedback 2023-04-19 15:58:04 +02:00
Richard Antalik 42483e70b6 Merge branch 'main' into retiming-sound-2
buildbot/vexp-code-patch-coordinator Build done. Details
2023-04-17 18:17:30 +02:00
Richard Antalik 2c03048513 remove unused argument 2023-04-07 00:09:19 +02:00
Richard Antalik 788512fb02 Fix incorrect seeking when retimed sound is outside of strip boundary. 2023-04-06 23:32:24 +02:00
Richard Antalik cf00b351a8 Rename functions as suggested 2023-04-06 22:26:56 +02:00
Richard Antalik d475fb0cea Fix incorrect seeking when strip has start offset 2023-04-05 23:54:44 +02:00
Richard Antalik 78d8b02a15 Fix use after free.
Still don't quite understand how std::shared_ptr is supposed to be used, but I think this is corect way.
2023-04-05 19:33:02 +02:00
Richard Antalik a2d25e46f6 Fix incorrect seeking when strip doesn't start at frame 1 2023-04-05 01:28:29 +02:00
Richard Antalik 238d60e962 Remove unnecessary `using` kw 2023-04-04 23:13:22 +02:00
Richard Antalik 697feb9b42 Merge branch 'main' into retiming-sound-2 2023-04-04 21:58:58 +02:00
Richard Antalik 07debd9213 - Pass `SequenceData` reference to `SequenceEntry` instead of fps,
- Apply pitch to subframe seek offset
2023-03-21 18:41:45 +01:00
Richard Antalik 4793a0e540 clang-format 2023-03-21 17:49:15 +01:00
Richard Antalik 30b56abb01 VSE: Add sound strip retiming support
buildbot/vexp-code-patch-coordinator Build done. Details
This patch contains changes needed for retiming sound strips. This is a part of blender/blender#104544

----

Deviation from blender/blender#100337 is, that changes in audaspace are not separated.
Versioning for old files is not present, because resulting data is unusable (whole animation is baked, so changing retiming is basically impossible). Versioning also results in precision issues which results in non uniform sound pitch in some cases. And finally calculating strip offset correction is non-trivial (that is least of an issue, but worth mentioning still). So I would advocate to not convert old data to current implementation. I think, that supporting smooth speed transitions would allow for more efficient versioning code.
2023-02-22 13:55:50 +01:00