blender
/
blender
137
411
Fork 595
Code Issues 6.3k Pull Requests 770 Projects 19 Wiki Activity

Fix: Targa with Palette Shows Grayscale in Viewport. #106047

Merged
Jeroen Bakker merged 3 commits from Jeroen-Bakker/blender:image-target-draws-grayscale into main 2023-03-24 07:46:44 +01:00
Conversation 1 Commits 3 Files Changed 1 +1 -6
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
source/blender/imbuf/intern/targa.c
View File

@ -676,12 +676,7 @@ ImBuf *imb_loadtarga(const uchar *mem, size_t mem_size, int flags, char colorspa
cmap[count] = cp_data; cmap[count] = cp_data;
} }
size = 0; ibuf->planes = tga.mapbits;
Sergey Sharybin commented 2023-03-23 16:38:30 +01:00
Outdated
Review
Copy Link

Not sure the comment is that useful. It is not the only place where the assignment to the planes happens, and the GPU sides optimizations might change in the future.

To me the ibuf->places = tga.mapbits seems clear by itself.

Not sure the comment is that useful. It is not the only place where the assignment to the planes happens, and the GPU sides optimizations might change in the future. To me the `ibuf->places = tga.mapbits` seems clear by itself.
for (int cmap_index = cmap_max - 1; cmap_index > 0; cmap_index >>= 1) {
size++;
}
ibuf->planes = size;
if (tga.mapbits != 32) { /* Set alpha bits. */ if (tga.mapbits != 32) { /* Set alpha bits. */
cmap[0] &= BIG_LONG(0x00ffffffl); cmap[0] &= BIG_LONG(0x00ffffffl);
} }