blender
/
blender
133
398
Fork 579
Code Issues 6.3k Pull Requests 749 Projects 19 Wiki Activity

Fix: Metal null buffer initialization #106807

Merged
Jeroen Bakker merged 1 commits from Jason-Fielder/blender:MetalFixNullBuffer into main 2023-04-14 07:59:58 +02:00
Conversation 0 Commits 1 Files Changed 1 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
source/blender/gpu/metal/mtl_context.mm
View File

@ -497,7 +497,7 @@ id<MTLBuffer> MTLContext::get_null_buffer()
null_buffer_ = [this->device newBufferWithLength:null_buffer_size
options:MTLResourceStorageModeManaged];
[null_buffer_ retain];
uint32_t *null_data = (uint32_t *)calloc(0, null_buffer_size);
uint32_t *null_data = (uint32_t *)calloc(1, null_buffer_size);
memcpy([null_buffer_ contents], null_data, null_buffer_size);
Jeroen Bakker commented 2023-04-14 07:57:01 +02:00
Review
Copy Link

Is there a reason why memset isn't used here? This seems like a potential waste of mem and cpu cycles.

Is there a reason why memset isn't used here? This seems like a potential waste of mem and cpu cycles.
[null_buffer_ didModifyRange:NSMakeRange(0, null_buffer_size)];
free(null_data);