blender
/
blender
134
398
Fork 581
Code Issues 6.3k Pull Requests 757 Projects 19 Wiki Activity

I18n: translate node group socket type and subtype #107100

Merged
Bastien Montagne merged 1 commits from pioverfour/blender:dp_translate_node_group_socket_type into main 2023-05-16 14:53:36 +02:00
Conversation 1 Commits 1 Files Changed 2 +5 -6
2 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
scripts/modules/bl_i18n_utils/bl_extract_messages.py
View File

@ -204,7 +204,7 @@ def dump_rna_messages(msgs, reports, settings, verbose=False):
def class_blacklist():
blacklist_rna_class = {getattr(bpy.types, cls_id) for cls_id in (
# core classes
"Context", "Event", "Function", "UILayout", "UnknownType", "Property", "Struct",
"Context", "Event", "Function", "UILayout", "UnknownType", "Struct",
Bastien Montagne commented 2023-05-15 12:13:02 +02:00
Review
Copy Link

I find it weird that you need to remove this from the blacklist.... can you elaborate on the why?

I find it weird that you need to remove this from the blacklist.... can you elaborate on the why?
Damien Picard commented 2023-05-15 12:50:26 +02:00
Review
Copy Link

Yes, Time (Scene Relative) and Time (Absolute) are both defined as part of bpy.types.Property:

print(bpy.types.Property.bl_rna.properties['subtype'].enum_items.get("TIME").name)  # Time (Scene Relative)
print(bpy.types.Property.bl_rna.properties['subtype'].enum_items.get("TIME_ABSOLUTE").name)  # Time (Absolute)

They are not extracted from anywhere else.

Is there a better way to extract just those?

Yes, `Time (Scene Relative)` and `Time (Absolute)` are both defined as part of `bpy.types.Property`: ```python print(bpy.types.Property.bl_rna.properties['subtype'].enum_items.get("TIME").name) # Time (Scene Relative) print(bpy.types.Property.bl_rna.properties['subtype'].enum_items.get("TIME_ABSOLUTE").name) # Time (Absolute) ``` They are not extracted from anywhere else. Is there a better way to extract just those?
Bastien Montagne commented 2023-05-15 17:53:35 +02:00
Review
Copy Link

Mmmm I see.... But are these strings actually shown in the UI? In theory this should only be API-related, they are not expected to be exposed directly to the user in the UI :|

Mmmm I see.... But are these strings actually shown in the UI? In theory this should only be API-related, they are not expected to be exposed directly to the user in the UI :|
Damien Picard commented 2023-05-15 17:54:54 +02:00
Review
Copy Link

They are since e7f395dd20

They are since e7f395dd20
# registerable classes
"Panel", "Menu", "Header", "RenderEngine", "Operator", "OperatorMacro", "Macro", "KeyingSetInfo",
)

9
scripts/startup/bl_ui/space_node.py
View File

@ -885,7 +885,8 @@ class NodeTreeInterfacePanel(Panel):
props = property_row.operator_menu_enum(
"node.tree_socket_change_type",
"socket_type",
text=active_socket.bl_label if active_socket.bl_label else active_socket.bl_idname,
text=(iface_(active_socket.bl_label) if active_socket.bl_label
else iface_(active_socket.bl_idname)),
)
props.in_out = in_out
@ -903,10 +904,8 @@ class NodeTreeInterfacePanel(Panel):
props = property_row.operator_menu_enum(
"node.tree_socket_change_subtype",
"socket_subtype",
text=(
active_socket.bl_subtype_label if active_socket.bl_subtype_label else
active_socket.bl_idname
),
text=(iface_(active_socket.bl_subtype_label) if active_socket.bl_subtype_label
else iface_(active_socket.bl_idname)),
)
layout.use_property_split = True