blender
/
blender
133
398
Fork 579
Code Issues 6.3k Pull Requests 746 Projects 19 Wiki Activity

UI: Remove duplicate subsequent separators in Properties Navbar Tabs #107693

Merged
Harley Acheson merged 3 commits from guishe/blender:property-separator into main 2023-06-07 18:02:01 +02:00
Conversation 2 Commits 3 Files Changed 1 +6 -1
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
source/blender/makesrna/intern/rna_space.c
View File

@ -2047,13 +2047,18 @@ static const EnumPropertyItem *rna_SpaceProperties_context_itemf(bContext *UNUSE
BLI_assert(totitem <= ARRAY_SIZE(context_tabs_array));
int totitem_added = 0;
bool add_separator = true;
for (int i = 0; i < totitem; i++) {
if (context_tabs_array[i] == -1) {
RNA_enum_item_add_separator(&item, &totitem_added);
if (add_separator) {
RNA_enum_item_add_separator(&item, &totitem_added);
add_separator = false;
}
Harley Acheson commented 2023-06-07 00:18:47 +02:00
Outdated
Review
Copy Link

picky, but could not remove the blank line above? Looks to be an accidental change.

picky, but could not remove the blank line above? Looks to be an accidental change.
Guillermo Venegas commented 2023-06-07 00:28:03 +02:00
Outdated
Review
Copy Link

reverted!

reverted!
continue;
}
RNA_enum_items_add_value(&item, &totitem_added, buttons_context_items, context_tabs_array[i]);
add_separator = true;
/* Add the object data icon dynamically for the data tab. */
if (context_tabs_array[i] == BCONTEXT_DATA) {