UI: Fix and improve a few messages #108227

Merged
Hans Goudey merged 2 commits from pioverfour/blender:dp_fix_messages into blender-v3.6-release 2023-05-24 16:33:40 +02:00
16 changed files with 29 additions and 29 deletions
Showing only changes of commit 91cf2c7091 - Show all commits

View File

@ -1651,7 +1651,7 @@ class SEQUENCER_PT_source(SequencerButtonsPanel, Panel):
col = col.column(align=True)
split = col.split(factor=0.5, align=False)
split.alignment = 'RIGHT'
split.label(text="Samplerate")
split.label(text="Sample rate")

Should be two words

Should be two words

Since this is a UI label, title case here-- "Sample Rate"

Since this is a UI label, title case here-- "Sample Rate"
split.alignment = 'LEFT'
if sound.samplerate <= 0:
split.label(text="Unknown")

View File

@ -755,7 +755,7 @@ void MESH_OT_loopcut(wmOperatorType *ot)
prop = RNA_def_property(ot->srna, "falloff", PROP_ENUM, PROP_NONE);
RNA_def_property_enum_items(prop, rna_enum_proportional_falloff_curve_only_items);
RNA_def_property_enum_default(prop, PROP_INVSQUARE);
RNA_def_property_ui_text(prop, "Falloff", "Falloff type the feather");
RNA_def_property_ui_text(prop, "Falloff", "Falloff type of the feather");

Typo: forgotten "of"

Typo: forgotten "of"
RNA_def_property_translation_context(prop,
BLT_I18NCONTEXT_ID_CURVE_LEGACY); /* Abusing id_curve :/ */

View File

@ -1135,7 +1135,7 @@ static void rna_def_scopes(BlenderRNA *brna)
{SCOPES_WAVEFRM_RGB_PARADE, "PARADE", ICON_COLOR, "Parade", ""},
{SCOPES_WAVEFRM_YCC_601, "YCBCR601", ICON_COLOR, "YCbCr (ITU 601)", ""},
{SCOPES_WAVEFRM_YCC_709, "YCBCR709", ICON_COLOR, "YCbCr (ITU 709)", ""},
{SCOPES_WAVEFRM_YCC_JPEG, "YCBCRJPG", ICON_COLOR, "YCbCr (Jpeg)", ""},
{SCOPES_WAVEFRM_YCC_JPEG, "YCBCRJPG", ICON_COLOR, "YCbCr (JPEG)", ""},

JPEG, OpenJPEG and JPEG 2000 are the official spellings of the
respective projects.

JPEG, OpenJPEG and JPEG 2000 are the official spellings of the respective projects.
{SCOPES_WAVEFRM_RGB, "RGB", ICON_COLOR, "Red Green Blue", ""},
{0, NULL, 0, NULL, NULL},
};

View File

@ -3968,7 +3968,7 @@ static void rna_def_modifier_gpencillineart(BlenderRNA *brna)
RNA_def_property_ui_text(
prop,
"Image Boundary Trimming",
"Trim all edges right at the boundary of image(including overscan region)");
"Trim all edges right at the boundary of image (including overscan region)");

Missing space.

Missing space.
prop = RNA_def_property(srna, "use_back_face_culling", PROP_BOOLEAN, PROP_NONE);
RNA_def_property_boolean_sdna(prop, NULL, "calculation_flags", LRT_USE_BACK_FACE_CULLING);

View File

@ -311,7 +311,7 @@ static void rna_def_lattice(BlenderRNA *brna)
RNA_def_property_range(prop, 1, 64);
RNA_def_property_clear_flag(prop, PROP_ANIMATABLE);
RNA_def_property_ui_text(
prop, "U", "Point in U direction (can't be changed when there are shape keys)");
prop, "U", "Points in U direction (cannot be changed when there are shape keys)");

Plural, it is a collection of multiple points. Also do not use contraction for "cannot".

Plural, it is a collection of multiple points. Also do not use contraction for "cannot".
RNA_def_property_update(prop, 0, "rna_Lattice_update_size");
RNA_def_property_editable_func(prop, "rna_Lattice_size_editable");
@ -321,7 +321,7 @@ static void rna_def_lattice(BlenderRNA *brna)
RNA_def_property_range(prop, 1, 64);
RNA_def_property_clear_flag(prop, PROP_ANIMATABLE);
RNA_def_property_ui_text(
prop, "V", "Point in V direction (can't be changed when there are shape keys)");
prop, "V", "Points in V direction (cannot be changed when there are shape keys)");

Plural, it is a collection of multiple points. Also do not use contraction for "cannot".

Plural, it is a collection of multiple points. Also do not use contraction for "cannot".
RNA_def_property_update(prop, 0, "rna_Lattice_update_size");
RNA_def_property_editable_func(prop, "rna_Lattice_size_editable");
@ -331,7 +331,7 @@ static void rna_def_lattice(BlenderRNA *brna)
RNA_def_property_range(prop, 1, 64);
RNA_def_property_clear_flag(prop, PROP_ANIMATABLE);
RNA_def_property_ui_text(
prop, "W", "Point in W direction (can't be changed when there are shape keys)");
prop, "W", "Points in W direction (cannot be changed when there are shape keys)");

Plural, it is a collection of multiple points. Also do not use contraction for "cannot".

Plural, it is a collection of multiple points. Also do not use contraction for "cannot".
RNA_def_property_update(prop, 0, "rna_Lattice_update_size");
RNA_def_property_editable_func(prop, "rna_Lattice_size_editable");

View File

@ -2792,7 +2792,7 @@ static void rna_def_mvert(BlenderRNA *brna)
RNA_def_property_float_funcs(
prop, "rna_MeshVertex_bevel_weight_get", "rna_MeshVertex_bevel_weight_set", NULL);
RNA_def_property_ui_text(
prop, "Bevel Weight", "Weight used by the Bevel modifier 'Only Vertices' option");
prop, "Bevel Weight", "Weight used by the Bevel modifier Vertices mode");

The Bevel modifier's "Only Vertices" option was replaced by a Vertices mode in 2.90.

The Bevel modifier's "Only Vertices" option was replaced by a Vertices mode in 2.90.
RNA_def_property_update(prop, 0, "rna_Mesh_update_data_legacy_deg_tag_all");
prop = RNA_def_property(srna, "groups", PROP_COLLECTION, PROP_NONE);

View File

@ -189,7 +189,7 @@ static void rna_def_metaelement(BlenderRNA *brna)
/* enums */
prop = RNA_def_property(srna, "type", PROP_ENUM, PROP_NONE);
RNA_def_property_enum_items(prop, rna_enum_metaelem_type_items);
RNA_def_property_ui_text(prop, "Type", "Metaball types");
RNA_def_property_ui_text(prop, "Type", "Metaball type");

Affects one object, should be singular.

Affects one object, should be singular.
RNA_def_property_update(prop, 0, "rna_MetaBall_update_data");
/* number values */
@ -319,7 +319,7 @@ static void rna_def_metaball(BlenderRNA *brna)
};
srna = RNA_def_struct(brna, "MetaBall", "ID");
RNA_def_struct_ui_text(srna, "MetaBall", "Metaball data-block to defined blobby surfaces");
RNA_def_struct_ui_text(srna, "MetaBall", "Metaball data-block to define blobby surfaces");

Typo.

Typo.
RNA_def_struct_ui_icon(srna, ICON_META_DATA);
prop = RNA_def_property(srna, "elements", PROP_COLLECTION, PROP_NONE);
@ -340,7 +340,7 @@ static void rna_def_metaball(BlenderRNA *brna)
RNA_def_property_float_sdna(prop, NULL, "wiresize");
RNA_def_property_range(prop, 0.005f, 10000.0f);
RNA_def_property_ui_range(prop, 0.05f, 1000.0f, 2.5f, 3);
RNA_def_property_ui_text(prop, "Wire Size", "Polygonization resolution in the 3D viewport");
RNA_def_property_ui_text(prop, "Viewport Size", "Polygonization resolution in the 3D viewport");

This option has nothing to do with wireframes, I suppose it's an old terminology.

This option has nothing to do with wireframes, I suppose it's an old terminology.
RNA_def_property_update(prop, 0, "rna_MetaBall_update_data");
prop = RNA_def_property(srna, "render_resolution", PROP_FLOAT, PROP_DISTANCE);

View File

@ -2431,7 +2431,7 @@ static void rna_def_modifier_wave(BlenderRNA *brna)
RNA_def_property_ui_text(
prop,
"Time Offset",
"Either the starting frame (for positive speed) or ending frame (for negative speed.)");
"Either the starting frame (for positive speed) or ending frame (for negative speed)");

Trailing period.

Trailing period.
RNA_def_property_update(prop, 0, "rna_Modifier_update");
prop = RNA_def_property(srna, "lifetime", PROP_FLOAT, PROP_TIME);
@ -2769,7 +2769,7 @@ static void rna_def_modifier_boolean(BlenderRNA *brna)
0,
"Index Based",
"Set the material on new faces based on the order of the material slot lists. If a "
"material doesn't exist on the modifier object, the face will use the same material slot "
"material doesn't exist on the modified object, the face will use the same material slot "

An object is either modified, or is affected by a modifier.

An object is either modified, or is affected by a modifier.

I think "modifier object" is a used as a noun meaning "the object that owns the modifier". It's probably used in a couple other places too. "modifier's object" would be reasonable too I guess. But I'm not sure this is worth changing TBH

I think "modifier object" is a used as a noun meaning "the object that owns the modifier". It's probably used in a couple other places too. "modifier's object" would be reasonable too I guess. But I'm not sure this is worth changing TBH

Right, it’s probably clear enough as is. Reverting!

Right, it’s probably clear enough as is. Reverting!
"or the first if the object doesn't have enough slots"},
{eBooleanModifierMaterialMode_Transfer,
"TRANSFER",
@ -3336,7 +3336,7 @@ static void rna_def_modifier_correctivesmooth(BlenderRNA *brna)
RNA_def_property_float_sdna(prop, NULL, "lambda");
RNA_def_property_range(prop, -FLT_MAX, FLT_MAX);
RNA_def_property_ui_range(prop, 0.0, 1.0, 5, 3);
RNA_def_property_ui_text(prop, "Lambda Factor", "Smooth factor effect");
RNA_def_property_ui_text(prop, "Lambda Factor", "Smooth effect factor");

The prop describes a factor for an effect, not an effect for a factor.

The prop describes a factor for an effect, not an effect for a factor.
RNA_def_property_update(prop, 0, "rna_CorrectiveSmoothModifier_update");
prop = RNA_def_property(srna, "iterations", PROP_INT, PROP_NONE);
@ -3440,7 +3440,7 @@ static void rna_def_modifier_laplaciansmooth(BlenderRNA *brna)
RNA_def_property_float_sdna(prop, NULL, "lambda");
RNA_def_property_range(prop, -FLT_MAX, FLT_MAX);
RNA_def_property_ui_range(prop, -1000.0, 1000.0, 5, 3);
RNA_def_property_ui_text(prop, "Lambda Factor", "Smooth factor effect");
RNA_def_property_ui_text(prop, "Lambda Factor", "Smooth effect factor");

The prop describes a factor for an effect, not an effect for a factor.

image

The prop describes a factor for an effect, not an effect for a factor. ![image](/attachments/fd2a58c2-a933-458f-96f4-b43e500f2b5a)
RNA_def_property_update(prop, 0, "rna_Modifier_update");
prop = RNA_def_property(srna, "lambda_border", PROP_FLOAT, PROP_NONE);
@ -4768,7 +4768,7 @@ static void rna_def_modifier_solidify(BlenderRNA *brna)
RNA_def_property_boolean_sdna(prop, NULL, "flag", MOD_SOLIDIFY_NONMANIFOLD_FLAT_FACES);
RNA_def_property_ui_text(prop,
"Flat Faces",
"Make faces use the minimal vertex weight assigned to their vertices"
"Make faces use the minimal vertex weight assigned to their vertices "

Missing space.

Missing space.
"(ensures new faces remain parallel to their original ones, slow, "
"disable when not needed)");
RNA_def_property_update(prop, 0, "rna_Modifier_update");

View File

@ -4742,7 +4742,7 @@ static const EnumPropertyItem node_flip_items[] = {
static const EnumPropertyItem node_ycc_items[] = {
{0, "ITUBT601", 0, "ITU 601", ""},
{1, "ITUBT709", 0, "ITU 709", ""},
{2, "JFIF", 0, "Jpeg", ""},
{2, "JFIF", 0, "JPEG", ""},

JPEG, OpenJPEG and JPEG 2000 are the official spellings of the
respective projects.

JPEG, OpenJPEG and JPEG 2000 are the official spellings of the respective projects.
{0, NULL, 0, NULL, NULL},
};

View File

@ -3641,7 +3641,7 @@ static void rna_def_object(BlenderRNA *brna)
prop = RNA_def_property(srna, "color", PROP_FLOAT, PROP_COLOR);
RNA_def_property_ui_text(
prop, "Color", "Object color and alpha, used when faces have the ObColor mode enabled");
prop, "Color", "Object color and alpha, used when the Object Color mode is enabled");

ObColor is not used anywhere else in the UI (since Blender 2.50).

ObColor is not used anywhere else in the UI (since Blender 2.50).
RNA_def_property_update(prop, NC_OBJECT | ND_DRAW, "rna_Object_internal_update_draw");
/* physics */

View File

@ -2576,7 +2576,7 @@ static void rna_def_particle_settings(BlenderRNA *brna)
prop = RNA_def_property(srna, "apply_effector_to_children", PROP_BOOLEAN, PROP_NONE);
RNA_def_property_boolean_sdna(prop, NULL, "flag", PART_CHILD_EFFECT);
RNA_def_property_ui_text(prop, "Effect Children", "Apply effectors to children");
RNA_def_property_ui_text(prop, "Affect Children", "Apply effectors to children");

Misspelling.

Misspelling.
RNA_def_property_update(prop, 0, "rna_Particle_redo");
prop = RNA_def_property(srna, "create_long_hair_children", PROP_BOOLEAN, PROP_NONE);

View File

@ -4247,7 +4247,7 @@ static void rna_def_statvis(BlenderRNA *brna)
RNA_def_property_float_sdna(prop, NULL, "sharp_min");
RNA_def_property_range(prop, -DEG2RADF(180.0f), DEG2RADF(180.0f));
RNA_def_property_ui_range(prop, -DEG2RADF(180.0f), DEG2RADF(180.0f), 10, 3);
RNA_def_property_ui_text(prop, "Distort Min", "Minimum angle to display");
RNA_def_property_ui_text(prop, "Sharpness Min", "Minimum angle to display");

Copy-pasted from another pair of properties.

Copy-pasted from another pair of properties.
RNA_def_property_flag(prop, PROP_CONTEXT_UPDATE);
RNA_def_property_update(prop, 0, "rna_EditMesh_update");
@ -4255,7 +4255,7 @@ static void rna_def_statvis(BlenderRNA *brna)
RNA_def_property_float_sdna(prop, NULL, "sharp_max");
RNA_def_property_range(prop, -DEG2RADF(180.0f), DEG2RADF(180.0f));
RNA_def_property_ui_range(prop, -DEG2RADF(180.0f), DEG2RADF(180.0f), 10, 3);
RNA_def_property_ui_text(prop, "Distort Max", "Maximum angle to display");
RNA_def_property_ui_text(prop, "Sharpness Max", "Maximum angle to display");

Copy-pasted from another pair of properties.

Copy-pasted from another pair of properties.
RNA_def_property_flag(prop, PROP_CONTEXT_UPDATE);
RNA_def_property_update(prop, 0, "rna_EditMesh_update");
}
@ -5917,18 +5917,18 @@ static void rna_def_scene_image_format_data(BlenderRNA *brna)
prop = RNA_def_property(srna, "use_jpeg2k_cinema_preset", PROP_BOOLEAN, PROP_NONE);
RNA_def_property_boolean_sdna(prop, NULL, "jp2_flag", R_IMF_JP2_FLAG_CINE_PRESET);
RNA_def_property_ui_text(prop, "Cinema", "Use Openjpeg Cinema Preset");
RNA_def_property_ui_text(prop, "Cinema", "Use OpenJPEG Cinema Preset");

JPEG, OpenJPEG and JPEG 2000 are the official spellings of the
respective projects.

JPEG, OpenJPEG and JPEG 2000 are the official spellings of the respective projects.
RNA_def_property_update(prop, NC_SCENE | ND_RENDER_OPTIONS, NULL);
prop = RNA_def_property(srna, "use_jpeg2k_cinema_48", PROP_BOOLEAN, PROP_NONE);
RNA_def_property_boolean_sdna(prop, NULL, "jp2_flag", R_IMF_JP2_FLAG_CINE_48);
RNA_def_property_ui_text(prop, "Cinema (48)", "Use Openjpeg Cinema Preset (48fps)");
RNA_def_property_ui_text(prop, "Cinema (48)", "Use OpenJPEG Cinema Preset (48fps)");

JPEG, OpenJPEG and JPEG 2000 are the official spellings of the
respective projects.

JPEG, OpenJPEG and JPEG 2000 are the official spellings of the respective projects.
RNA_def_property_update(prop, NC_SCENE | ND_RENDER_OPTIONS, NULL);
prop = RNA_def_property(srna, "jpeg2k_codec", PROP_ENUM, PROP_NONE);
RNA_def_property_enum_sdna(prop, NULL, "jp2_codec");
RNA_def_property_enum_items(prop, jp2_codec_items);
RNA_def_property_ui_text(prop, "Codec", "Codec settings for Jpeg2000");
RNA_def_property_ui_text(prop, "Codec", "Codec settings for JPEG 2000");

JPEG, OpenJPEG and JPEG 2000 are the official spellings of the
respective projects.

JPEG, OpenJPEG and JPEG 2000 are the official spellings of the respective projects.
RNA_def_property_update(prop, NC_SCENE | ND_RENDER_OPTIONS, NULL);
# endif
@ -6257,7 +6257,7 @@ static void rna_def_scene_ffmpeg_settings(BlenderRNA *brna)
RNA_def_property_int_sdna(prop, NULL, "audio_mixrate");
RNA_def_property_clear_flag(prop, PROP_ANIMATABLE);
RNA_def_property_range(prop, 8000, 192000);
RNA_def_property_ui_text(prop, "Samplerate", "Audio samplerate(samples/s)");
RNA_def_property_ui_text(prop, "Sample rate", "Audio sample rate (samples/s)");

Sample rate: should be two words.

Sample rate: should be two words.
RNA_def_property_update(prop, NC_SCENE | ND_RENDER_OPTIONS, NULL);
prop = RNA_def_property(srna, "audio_channels", PROP_ENUM, PROP_NONE);

View File

@ -89,7 +89,7 @@ static void rna_def_sound(BlenderRNA *brna)
prop = RNA_def_property(srna, "samplerate", PROP_INT, PROP_NONE);
RNA_def_property_int_sdna(prop, NULL, "samplerate");
RNA_def_property_clear_flag(prop, PROP_EDITABLE);
RNA_def_property_ui_text(prop, "Samplerate", "Samplerate of the audio in Hz");
RNA_def_property_ui_text(prop, "Sample rate", "Sample rate of the audio in Hz");

Sample rate: should be two words.

Sample rate: should be two words.
prop = RNA_def_property(srna, "channels", PROP_ENUM, PROP_NONE);
RNA_def_property_enum_sdna(prop, NULL, "audio_channels");

View File

@ -4775,7 +4775,7 @@ static void rna_def_userdef_view(BlenderRNA *brna)
RNA_def_property_range(prop, 0, 1000);
RNA_def_property_ui_text(prop,
"Tap Key Timeout",
"Pie menu button held longer than this will dismiss menu on release."
"Pie menu button held longer than this will dismiss menu on release "

Replace period with space.

Replace period with space.
"(in 1/100ths of sec)");
prop = RNA_def_property(srna, "pie_animation_timeout", PROP_INT, PROP_NONE);

View File

@ -39,7 +39,7 @@ static void cmp_node_lensdist_declare(NodeDeclarationBuilder &b)
b.add_input<decl::Color>("Image")
.default_value({1.0f, 1.0f, 1.0f, 1.0f})
.compositor_domain_priority(0);
b.add_input<decl::Float>("Distort")
b.add_input<decl::Float>("Distortion")

Socket in the lens distortion node should be a noun, same as "Dispersion" just below.

Socket in the lens distortion node should be a noun, same as "Dispersion" just below.

Node socket identifiers generally can't be changed without versioning (see version_node_socket_name). Probably best to do this separately.

Node socket identifiers generally can't be changed without versioning (see `version_node_socket_name`). Probably best to do this separately.

I hadn’t thought of that, I’ll have a look at it.

I hadn’t thought of that, I’ll have a look at it.
.default_value(0.0f)
.min(MINIMUM_DISTORTION)
.max(1.0f)

View File

@ -13,7 +13,7 @@ static void node_declare(NodeDeclarationBuilder &b)
class ResolutionFieldInput final : public bke::CurvesFieldInput {
public:
ResolutionFieldInput() : bke::CurvesFieldInput(CPPType::get<int>(), "resolution")
ResolutionFieldInput() : bke::CurvesFieldInput(CPPType::get<int>(), "Resolution")

Field names should be capitalized.

Field names should be capitalized.
{
category_ = Category::NamedAttribute;
}