blender
/
blender
136
408
Fork 591
Code Issues 6.3k Pull Requests 775 Projects 19 Wiki Activity

Fix #109770: WM: Memory leak of timers for file browser report #109603

Closed
Iliya Katushenock wants to merge 3 commits from mod_moder:tmp_fix_mem_leak into main
pull from: mod_moder:tmp_fix_mem_leak
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 12 Commits 3 Files Changed 1 +1
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
source/blender/windowmanager/intern/wm.c
View File

@ -606,6 +606,7 @@ void wm_close_and_free(bContext *C, wmWindowManager *wm)
WM_drag_free_list(&wm->drags);
wm_reports_free(wm);
BLI_freelistN(&wm->timers);
Campbell Barton commented 2023-07-10 13:02:47 +02:00
Review
Copy Link

Timers can themselves have allocated data, this should be replaced by a function which frees timer custom data (see: WM_TIMER_NO_FREE_CUSTOM_DATA).

Suggest adding WM_event_timer_free_data(...) which WM_event_remove_timer can call too.

Timers can themselves have allocated data, this should be replaced by a function which frees timer custom data (see: `WM_TIMER_NO_FREE_CUSTOM_DATA`). Suggest adding `WM_event_timer_free_data(...)` which `WM_event_remove_timer` can call too.
if (wm->undo_stack) {
BKE_undosys_stack_destroy(wm->undo_stack);