blender
/
blender
137
418
Fork 600
Code Issues 6.3k Pull Requests 782 Projects 19 Wiki Activity

Mesh: Rewrite split edges algorithm #110661

Merged
Hans Goudey merged 78 commits from HooglyBoogly/blender:split-edges-rewrite-2 into main 2023-08-30 14:23:49 +02:00
Conversation 8 Commits 78 Files Changed 1 +1
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit fb7a21cd7a - Show all commits

1
source/blender/geometry/intern/mesh_split_edges.cc
View File

@ -69,6 +69,7 @@ static void propagate_edge_attributes(Mesh &mesh, const Span<int> new_to_old_edg
continue;
}
if (id.name() == ".edge_verts") {
HooglyBoogly marked this conversation as resolved
Wannes Malfait commented 2023-08-02 14:32:04 +02:00
Review
Copy Link

I assume this skips updating the vertex index information for the edges, since this is handled separately? Maybe worth mentioning this in a comment.

I assume this skips updating the vertex index information for the edges, since this is handled separately? Maybe worth mentioning this in a comment.
/* Edge vertices are updated and combined with new edges separately. */
continue;
}
bke::GSpanAttributeWriter attribute = attributes.lookup_for_write_span(id);