Mesh: Rewrite split edges algorithm #110661

Merged
Hans Goudey merged 78 commits from HooglyBoogly/blender:split-edges-rewrite-2 into main 2023-08-30 14:23:49 +02:00

78 Commits

Author SHA1 Message Date
Hans Goudey ff6d1cf562 Update calc_new_edges to avoid work when there are no merges 2023-08-30 08:05:48 -04:00
Hans Goudey 201cb34b62 Merge branch 'main' into split-edges-rewrite-2 2023-08-30 06:59:51 -04:00
Hans Goudey d600c69bfa Add comment about `add_edge_or_find_index` 2023-08-29 17:12:39 -04:00
Hans Goudey 1b53d4c7dd Remove vertex specific comments in function also used for edge indices 2023-08-29 17:10:34 -04:00
Hans Goudey 4dc7b6c7c9 Fix confusing wording in comment 2023-08-29 17:09:57 -04:00
Hans Goudey 415aebc3d5 Clarify meaning of `r_new_edge_offsets` with an alias 2023-08-29 17:09:02 -04:00
Hans Goudey a5cbdd9061 Merge branch 'main' into split-edges-rewrite-2 2023-08-29 17:06:07 -04:00
Hans Goudey 86dab51604 Fixes to new edge deduplication 2023-08-29 15:18:44 -04:00
Hans Goudey 1d3e5c7855 Merge branch 'main' into split-edges-rewrite-2 2023-08-29 12:56:18 -04:00
Hans Goudey 4e05cfda4e Progress 2023-08-29 12:50:47 -04:00
Hans Goudey c38fcb8242 Merge branch 'main' into split-edges-rewrite-2 2023-08-29 12:00:34 -04:00
Hans Goudey 9a827e8ad1 Progress 2023-08-29 11:58:02 -04:00
Hans Goudey 21062fc656 Merge branch 'main' into split-edges-rewrite-2 2023-08-29 11:47:56 -04:00
Hans Goudey e7e800281e Cleanup comments and naming 2023-08-28 19:48:49 -04:00
Hans Goudey 84eac93484 Merge branch 'main' into split-edges-rewrite-2 2023-08-28 17:02:09 -04:00
Hans Goudey 0d9a8bf1a8 Merge branch 'main' into split-edges-rewrite-2 2023-08-05 12:07:32 -04:00
Hans Goudey 2213285786 Progress 2023-08-03 17:32:22 -04:00
Hans Goudey c775ae798b Progress 2023-08-03 16:39:39 -04:00
Hans Goudey 0612dad45f Progress 2023-08-03 13:49:45 -04:00
Hans Goudey ff7efecb37 Progress 2023-08-03 13:06:59 -04:00
Hans Goudey fdb74eda2d Merge branch 'main' into split-edges-rewrite-2 2023-08-03 12:46:32 -04:00
Hans Goudey c0144ab5b6 Rename function 2023-08-03 11:20:06 -04:00
Hans Goudey 2672f0a904 Merge branch 'main' into split-edges-rewrite-2 2023-08-03 11:19:15 -04:00
Hans Goudey 3013aaf47e Progress 2023-08-03 10:36:21 -04:00
Hans Goudey 43095e91da Merge branch 'main' into split-edges-rewrite-2 2023-08-03 08:10:16 -04:00
Hans Goudey c96f0f0d22 Fix typo 2023-08-02 13:57:07 -04:00
Hans Goudey fe798771a0 Rename "fan" to "group" 2023-08-02 13:22:57 -04:00
Hans Goudey 004054bf29 Add r_ prefix, remove unnecessary return 2023-08-02 10:58:35 -04:00
Hans Goudey b6b5f76724 Rename `calc_merged_new_edges` -> `calc_no_split_selected_edges` 2023-08-02 10:57:36 -04:00
Hans Goudey b8d5fedd1e Add local span with better name than "offset_data" 2023-08-02 10:56:04 -04:00
Hans Goudey 78ef51dd58 Merge branch 'main' into split-edges-rewrite-2 2023-08-02 10:37:27 -04:00
Hans Goudey fb7a21cd7a Add comment about skipping edge verts in edge attribute loop 2023-08-02 09:46:38 -04:00
Hans Goudey 88b6c3ff6a Add a comment about filling -1 2023-08-02 09:45:35 -04:00
Hans Goudey 40c429b416 Rename "universe_size" to "total_size" 2023-08-02 09:42:32 -04:00
Hans Goudey f3ef2d052d Rename VertLooseEdges::split 2023-08-02 08:59:07 -04:00
Hans Goudey 34dff5aaa7 Improve comment about vertex mapping 2023-08-02 08:58:04 -04:00
Hans Goudey bcf2706b11 Fix "fan of edges" -> "fan of corners" in comments 2023-08-02 08:56:59 -04:00
Hans Goudey f87da6a61f Remove BKE_mesh_is_valid call in debug builds 2023-08-02 08:54:28 -04:00
Hans Goudey 9ce94cea9a Merge branch 'main' into split-edges-rewrite-2 2023-08-02 08:54:00 -04:00
Hans Goudey e1537744cd Use noinitialization when constructing corner fans
buildbot/vexp-code-patch-coordinator Build done. Details
Saves about 100ms out of 550
2023-08-01 16:06:14 -04:00
Hans Goudey 22e89dee1f Merge branch 'main' into split-edges-rewrite-2 2023-08-01 15:09:23 -04:00
Hans Goudey 6898599a7b Merge branch 'main' into split-edges-rewrite-2 2023-08-01 14:56:41 -04:00
Hans Goudey 7cd8198ac7 Final comments and renames 2023-07-31 16:46:40 -04:00
Hans Goudey 83b5459f75 Remove now-unrelated change 2023-07-31 16:46:34 -04:00
Hans Goudey 4fd6eae8fc Fix: remove extra verts 2023-07-31 16:19:21 -04:00
Hans Goudey 781f4bdaf1 Fix corner fan calculation 2023-07-31 16:05:53 -04:00
Hans Goudey 026e41b5f0 Fix corner edges of unselected edges 2023-07-31 15:17:47 -04:00
Hans Goudey 1ee785f8c6 Cleanup 2023-07-31 14:18:45 -04:00
Hans Goudey 364efd77e4 Progress 2023-07-31 14:18:22 -04:00
Hans Goudey 6d59557a78 Merge branch 'main' into split-edges-rewrite-2 2023-07-31 12:50:11 -04:00
Hans Goudey 2af5e3998b Start reusing original edges for first new split edge 2023-07-25 15:13:17 -04:00
Hans Goudey 0d3db725b0 Progress 2023-07-25 13:53:11 -04:00
Hans Goudey cf0c845ff0 Merge branch 'main' into split-edges-rewrite-2 2023-07-25 12:09:41 -04:00
Hans Goudey d446b4b272 Progress 2023-07-25 07:54:38 -04:00
Hans Goudey fa63a9e636 Merge branch 'main' into split-edges-rewrite-2 2023-07-24 17:52:22 -04:00
Hans Goudey bd34bf213a Merge branch 'main' into split-edges-rewrite-2 2023-07-15 15:17:10 -04:00
Hans Goudey 2a79f6aa67 Don't relink non-selected loose edges 2023-07-15 14:24:43 -04:00
Hans Goudey 9c010be43e Progress, still not working in most cases 2023-07-15 13:43:06 -04:00
Hans Goudey d8423683cd Cleanup 2023-07-14 16:36:34 -04:00
Hans Goudey 3caf545f94 Theoretically working in my head 2023-07-14 16:34:16 -04:00
Hans Goudey f7782116b1 Cleanup 2023-07-14 16:12:06 -04:00
Hans Goudey 6f82af0458 Merge branch 'main' into split-edges-rewrite-2 2023-07-14 16:11:22 -04:00
Hans Goudey a7e1f4ac7d Progress 2023-07-14 15:48:52 -04:00
Hans Goudey c73a2be382 Fix loose edge and corner fan calculation 2023-07-14 13:28:27 -04:00
Hans Goudey dcf621b97a Merge branch 'main' into split-edges-rewrite-2 2023-07-14 10:52:16 -04:00
Hans Goudey 8d3b998673 Remove unnecessary comment 2023-07-14 10:10:19 -04:00
Hans Goudey e98b7668b2 Update comment 2023-07-14 10:09:23 -04:00
Hans Goudey 637263090a Cleanup 2023-07-14 07:59:03 -04:00
Hans Goudey ef042cbb21 Merge branch 'main' into split-edges-rewrite-2 2023-07-14 07:32:11 -04:00
Hans Goudey 8909b1fa16 Start conversion of fan to store corner indices 2023-07-13 23:22:32 -04:00
Hans Goudey f066c05d8e Add todo comment 2023-07-13 23:15:00 -04:00
Hans Goudey be7de5e789 Progress 2023-07-13 23:11:16 -04:00
Hans Goudey 505fd28d63 Progress 2023-07-13 15:03:40 -04:00
Hans Goudey 45cb37d94c Cleanup 2023-07-13 14:34:19 -04:00
Hans Goudey 3d488830da Merge branch 'main' into split-edges-rewrite-2 2023-07-13 13:54:17 -04:00
Hans Goudey 5eb0128b19 Progress 2023-07-13 10:57:33 -04:00
Hans Goudey a90d71ddcc Merge branch 'main' into split-edges-rewrite-2 2023-07-13 07:24:09 -04:00
Hans Goudey f14b0a834b Mesh: Rewrite and fix split edges code 2023-07-13 07:11:14 -04:00