blender
/
blender
136
404
Fork 586
Code Issues 6.2k Pull Requests 754 Projects 19 Wiki Activity

Fix #111607: Do not unregister internal nodes #111615

Merged
YimingWu merged 2 commits from ChengduLittleA/blender:fix-111607 into main 2023-08-29 09:35:53 +02:00
Conversation 4 Commits 2 Files Changed 1 +3 -1
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source/blender/makesrna/intern/rna_nodetree.cc
View File

@ -1768,7 +1768,9 @@ static bool rna_Node_unregister(Main * /*bmain*/, StructRNA *type)
{
bNodeType *nt = static_cast<bNodeType *>(RNA_struct_blender_type_get(type));
if (!nt) {
/* `nt->rna_ext.data` is the python object. If it's nullptr then it's an
ChengduLittleA marked this conversation as resolved Outdated
Hans Goudey commented 2023-08-28 15:53:39 +02:00
Outdated
Review
Copy Link

Picky:

The /** comment format is meant for function/struct documentation. Comments inside of functions can just use /* like normal.

Also, it's a internally -> it's an internally

Picky: The `/**` comment format is meant for function/struct documentation. Comments inside of functions can just use `/*` like normal. Also, `it's a internally` -> `it's an internally`
* internally registered node, thus can't unregister. */
if (!nt || !nt->rna_ext.data) {
return false;
}