blender
/
blender
138
428
Fork 615
Code Issues 6.3k Pull Requests 789 Projects 19 Wiki Activity

UI: Node Grid Adjustments for Line Width #111640

Merged
Harley Acheson merged 2 commits from Harley/blender:NodeGrid into main 2023-08-29 06:33:30 +02:00
Conversation 2 Commits 2 Files Changed 3 +4 -3
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 19e91d9b1b - Show all commits

7
source/blender/editors/interface/view2d.cc
View File

@ -1331,7 +1331,7 @@ void UI_view2d_dot_grid_draw(const View2D *v2d,
clamp_f(point_size_precise, min_point_size, max_point_size));
/* Offset point by this amount to better align centers as size changes. */
const float point_size_offset = point_size_draw / 2.0f;
const float point_size_offset = (point_size_draw / 2.0f) - U.pixelsize;
/* To compensate the for the clamped point_size we adjust the alpha to make the overall
* brightness of the grid background more consistent. */
@ -1356,13 +1356,14 @@ void UI_view2d_dot_grid_draw(const View2D *v2d,
const float step = min_step * level_scale;
int count_x;
float start_x;
/* Count points that fit in viewport minus space for the scrollbars. */
Harley marked this conversation as resolved
Hans Goudey commented 2023-08-29 02:55:26 +02:00
Review
Copy Link

Could you split the 1.5 and 1.2 values to separate const float variables with descriptive names (if possible!) :)

Also, the parentheses are necessary, order of operations makes multiplication happen first.

Could you split the 1.5 and 1.2 values to separate `const float` variables with descriptive names (if possible!) :) Also, the parentheses are necessary, order of operations makes multiplication happen first.
Harley Acheson commented 2023-08-29 05:49:15 +02:00
Review
Copy Link

It got much nicer when I found some scrollbar size defines that work better and are self-explanatory.

It got much nicer when I found some scrollbar size defines that work better and are self-explanatory.
grid_axis_start_and_count(
step, v2d->cur.xmin, v2d->cur.xmax - (1.5f * U.widget_unit), &start_x, &count_x);
step, v2d->cur.xmin, v2d->cur.xmax - V2D_SCROLL_WIDTH, &start_x, &count_x);
int count_y;
float start_y;
grid_axis_start_and_count(
step, v2d->cur.ymin + (1.2f * U.widget_unit), v2d->cur.ymax, &start_y, &count_y);
step, v2d->cur.ymin + V2D_SCROLL_HEIGHT, v2d->cur.ymax, &start_y, &count_y);
if (count_x == 0 || count_y == 0) {
continue;
}