UI: Node Grid Adjustments for Line Width #111640

Harley Acheson · 2023-08-29T02:32:22+02:00

Harley Acheson commented

2023-08-29 02:32:22 +02:00

Have Line Width change Node Grid point size but NOT grid spacing.

This fixes some complaints in #109572, but not other unrelated issues.

The Node Snapping Grid currently has spacing that is related to U.widget_unit. Unfortunately this value changes not only with Resolution scale but also with line width. It isn't just that changing to "Wide Lines" will make the grid wider, but linear changes in Resolution scale do not result in linear changes in U.widget_unit. @lone_noel made this nice graph to illustrate that this measure is not linear:

Conversely, changing from Thin Lines to Wide Lines does not change the size of the individual dots of the grid. This is needed for accessibility reasons so that users with vision issues can make the dots more visible.

This PR changes the grid spacing to use a value that changes only with UI_SCALE_FAC. Using a multiple of this that will be exactly equal the current spacing at 1X, 2X, etc.

It also makes the grid dot size change with U.pixelsize (line width). It slightly offsets the dot position by half of its width to keep them centered as the dot size changes.

It also makes trivial changes to the calculation of the number of dots on the screen so that they can no longer overlap the scrollbars.

Have Line Width change Node Grid point size but NOT grid spacing. --- This fixes some complaints in #109572, but not other unrelated issues. The Node Snapping Grid currently has **spacing** that is related to `U.widget_unit`. Unfortunately this value changes not only with Resolution scale but also with line width. It isn't _just_ that changing to "Wide Lines" will make the grid wider, but linear changes in Resolution scale do not result in linear changes in `U.widget_unit`. @lone_noel made this nice graph to illustrate that this measure is not linear: ![image](/attachments/1554b0c5-016d-40c7-8fd9-4aa48fd2a896) Conversely, changing from Thin Lines to Wide Lines does not change the size of the individual dots of the grid. This is needed for accessibility reasons so that users with vision issues can make the dots more visible. This PR changes the grid spacing to use a value that changes only with UI_SCALE_FAC. Using a multiple of this that will be exactly equal the current spacing at 1X, 2X, etc. It also makes the grid dot size change with U.pixelsize (line width). It slightly offsets the dot position by half of its width to keep them centered as the dot size changes. It also makes trivial changes to the calculation of the number of dots on the screen so that they can no longer overlap the scrollbars.

image.png

157 KiB

❤️ 1

Harley Acheson added 1 commit 2023-08-29 02:32:32 +02:00

e0d9621d3e UI: Node Grid Adjustments for Line Width

Have Line Width change Node Grid point size but NOT grid spacing.

Harley Acheson added this to the User Interface project 2023-08-29 02:33:02 +02:00

Harley Acheson requested review from Hans Goudey 2023-08-29 02:33:09 +02:00

Hans Goudey approved these changes 2023-08-29 02:56:26 +02:00

source/blender/editors/interface/view2d.cc

						
				@ -1355,2 +1358,3 @@

				    float start_x;

				    grid_axis_start_and_count(step, v2d->cur.xmin, v2d->cur.xmax, &start_x, &count_x);

				    /* Count points that fit in viewport minus space for the scrollbars. */

				    grid_axis_start_and_count(

Hans Goudey commented

2023-08-29 02:55:26 +02:00

Could you split the 1.5 and 1.2 values to separate const float variables with descriptive names (if possible!) :)

Also, the parentheses are necessary, order of operations makes multiplication happen first.

Could you split the 1.5 and 1.2 values to separate `const float` variables with descriptive names (if possible!) :) Also, the parentheses are necessary, order of operations makes multiplication happen first.

Harley Acheson commented

2023-08-29 05:49:15 +02:00

It got much nicer when I found some scrollbar size defines that work better and are self-explanatory.

Harley marked this conversation as resolved

Harley Acheson added 1 commit 2023-08-29 05:48:08 +02:00