blender
/
blender
136
412
Fork 596
Code Issues 6.3k Pull Requests 775 Projects 19 Wiki Activity

Fix #111545: Regression: Crash when drawing all view layers in outliner #111646

Merged
Pratik Borhade merged 2 commits from PratikPB2123/blender:111545-outliner-crash into main 2023-08-29 14:11:32 +02:00
Conversation 2 Commits 2 Files Changed 1 +2 -1
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
source/blender/editors/space_outliner/tree/tree_display_view_layer.cc
View File

@ -80,8 +80,9 @@ ListBase TreeDisplayViewLayer::buildTree(const TreeSourceData &source_data)
add_view_layer(*scene, tree, (TreeElement *)nullptr);
}
else {
ViewLayerElementCreateData view_layer_data = {scene, view_layer};
Julian Eisel commented 2023-08-29 12:19:59 +02:00
Outdated
Review
Copy Link

Why the name new_layer? This isn't creating a new layer. Would use view_layer_data like in the other case this is done.

Why the name `new_layer`? This isn't creating a new layer. Would use `view_layer_data` like in the other case this is done.
Pratik Borhade commented 2023-08-29 12:25:58 +02:00
Outdated
Review
Copy Link

Right, I considered "new" view layer struct to name it

Right, I considered "new" view layer struct to name it
TreeElement &te_view_layer = *outliner_add_element(
&space_outliner_, &tree, view_layer, nullptr, TSE_R_LAYER, 0);
&space_outliner_, &tree, &view_layer_data, nullptr, TSE_R_LAYER, 0);
TreeStoreElem *tselem = TREESTORE(&te_view_layer);