blender
/
blender
136
407
Fork 589
Code Issues 6.3k Pull Requests 777 Projects 19 Wiki Activity

Mesh: Add operator to select elements based on boolean attribute #113772

Merged
Hans Goudey merged 3 commits from HooglyBoogly/blender:mesh-edit-select-by-attribute into blender-v4.0-release 2023-10-17 09:25:00 +02:00
Conversation 0 Commits 3 Files Changed 4 +10 -3
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 3240bd549a - Show all commits

13
source/blender/editors/mesh/editmesh_select.cc
View File

@ -5427,18 +5427,25 @@ static int edbm_select_by_attribute_exec(bContext *C, wmOperator * /*op*/)
continue;
}
bool changed = false;
Campbell Barton commented 2023-10-17 04:14:27 +02:00
Outdated
Review
Copy Link

Prefer to skip items when they're unchanged as this can add some overhead updating the display meshes, unnecessarily in some cases:

    changed = false;
    BMElem *elem;
    BMIter iter;
    BM_ITER_MESH (elem, &iter, bm, *iter_type) {
      if (BM_elem_flag_test(efa, BM_ELEM_HIDDEN | BM_ELEM_SELECT)) {
        continue; 
      } 
      if (BM_ELEM_CD_GET_BOOL(elem, layer->offset)) {
        BM_elem_select_set(bm, elem, true);
        changed = true;
      }
    }

    if (changed) {
      EDBM_selectmode_flush(em);

      DEG_id_tag_update(static_cast<ID *>(obedit->data), ID_RECALC_SELECT);
      WM_event_add_notifier(C, NC_GEOM | ND_SELECT, obedit->data);
    }
Prefer to skip items when they're unchanged as this can add some overhead updating the display meshes, unnecessarily in some cases: ``` changed = false; BMElem *elem; BMIter iter; BM_ITER_MESH (elem, &iter, bm, *iter_type) { if (BM_elem_flag_test(efa, BM_ELEM_HIDDEN | BM_ELEM_SELECT)) { continue; } if (BM_ELEM_CD_GET_BOOL(elem, layer->offset)) { BM_elem_select_set(bm, elem, true); changed = true; } } if (changed) { EDBM_selectmode_flush(em); DEG_id_tag_update(static_cast<ID *>(obedit->data), ID_RECALC_SELECT); WM_event_add_notifier(C, NC_GEOM | ND_SELECT, obedit->data); } ```
👍 1
BMElem *elem;
BMIter iter;
BM_ITER_MESH (elem, &iter, bm, *iter_type) {
if (BM_elem_flag_test(elem, BM_ELEM_HIDDEN | BM_ELEM_SELECT)) {
continue;
}
if (BM_ELEM_CD_GET_BOOL(elem, layer->offset)) {
BM_elem_select_set(bm, elem, true);
changed = true;
}
}
EDBM_selectmode_flush(em);
if (changed) {
EDBM_selectmode_flush(em);
DEG_id_tag_update(static_cast<ID *>(obedit->data), ID_RECALC_SELECT);
WM_event_add_notifier(C, NC_GEOM | ND_SELECT, obedit->data);
DEG_id_tag_update(static_cast<ID *>(obedit->data), ID_RECALC_SELECT);
WM_event_add_notifier(C, NC_GEOM | ND_SELECT, obedit->data);
}
}
MEM_freeN(objects);