Mesh: Add operator to select elements based on boolean attribute #113772

Hans Goudey · 2023-10-16T14:18:44+02:00

Hans Goudey commented

2023-10-16 14:18:44 +02:00

Adds a "Select by Attribute" operator as mentioned in the discussion in
#105317. This is done in 4.0 to limit the breaking aspect of the removal
of face maps. The selection storage functionality is replaced by boolean
attributes. We already have a way to control the data in the boolean
attribute with the "Set Attribute" operator, but we didn't have a way to
convert the attribute into a selection.

This operator works on the active attribute if is a boolean attribute
and isn't on the face corner domain. It adds to the existing selection
similar to other existing operators.

While this behavior can be recreated as a node tool, we add it as a
builtin operator here to avoid limitations of the new node-based
tool system and to make the late-in-the-release-cycle change safer.

Adds a "Select by Attribute" operator as mentioned in the discussion in #105317. This is done in 4.0 to limit the breaking aspect of the removal of face maps. The selection storage functionality is replaced by boolean attributes. We already have a way to control the data in the boolean attribute with the "Set Attribute" operator, but we didn't have a way to convert the attribute into a selection. This operator works on the active attribute if is a boolean attribute and isn't on the face corner domain. It adds to the existing selection similar to other existing operators. While this behavior can be recreated as a node tool, we add it as a builtin operator here to avoid limitations of the new node-based tool system and to make the late-in-the-release-cycle change safer. --- ![image](/attachments/6574f95d-4302-471f-8388-3e2090d57c9a)

image.png

14 KiB

Hans Goudey added this to the 4.0 milestone 2023-10-16 14:18:44 +02:00

Hans Goudey added the

Module

Modeling

label 2023-10-16 14:18:45 +02:00

Hans Goudey added 1 commit 2023-10-16 14:18:56 +02:00

Mesh: Add operator to select elements based on boolean attribute ebdf2e4aa5

Adds a "Select by Attribute" operator as mentioned in the discussion in
#105317. This is done in 4.0 to limit the breaking aspect of the removal
of face maps. The selection storage functionality is replaced by boolean
attributes. We already have a way to control the data in the boolean
attribute with the "Set Attribute" operator, but we didn't have a way to
convert the attribute into a selection.

This operator works on the active attribute if is a boolean attribute
and isn't on the face corner domain. It adds to the existing selection
similar to other existing operators.

While this behavior can be recreated as a node tool, we add it as a
builtin operator here to avoid limitations of the new node-based
tool system and to make the late-in-the-release-cycle change safer.

Campbell Barton approved these changes 2023-10-17 04:15:48 +02:00

Campbell Barton left a comment

Accepting with minor request.

source/blender/editors/mesh/editmesh_select.cc Outdated

						
				@ -5361,0 +5427,4 @@

				      continue;

				    }

				    BMElem *elem;

Campbell Barton commented

2023-10-17 04:14:27 +02:00

Prefer to skip items when they're unchanged as this can add some overhead updating the display meshes, unnecessarily in some cases:

    changed = false;
    BMElem *elem;
    BMIter iter;
    BM_ITER_MESH (elem, &iter, bm, *iter_type) {
      if (BM_elem_flag_test(efa, BM_ELEM_HIDDEN | BM_ELEM_SELECT)) {
        continue; 
      } 
      if (BM_ELEM_CD_GET_BOOL(elem, layer->offset)) {
        BM_elem_select_set(bm, elem, true);
        changed = true;
      }
    }

    if (changed) {
      EDBM_selectmode_flush(em);

      DEG_id_tag_update(static_cast<ID *>(obedit->data), ID_RECALC_SELECT);
      WM_event_add_notifier(C, NC_GEOM | ND_SELECT, obedit->data);
    }

Prefer to skip items when they're unchanged as this can add some overhead updating the display meshes, unnecessarily in some cases: ``` changed = false; BMElem *elem; BMIter iter; BM_ITER_MESH (elem, &iter, bm, *iter_type) { if (BM_elem_flag_test(efa, BM_ELEM_HIDDEN | BM_ELEM_SELECT)) { continue; } if (BM_ELEM_CD_GET_BOOL(elem, layer->offset)) { BM_elem_select_set(bm, elem, true); changed = true; } } if (changed) { EDBM_selectmode_flush(em); DEG_id_tag_update(static_cast<ID *>(obedit->data), ID_RECALC_SELECT); WM_event_add_notifier(C, NC_GEOM | ND_SELECT, obedit->data); } ```

👍 1

Hans Goudey added 2 commits 2023-10-17 09:24:06 +02:00

Merge branch 'blender-v4.0-release' into mesh-edit-select-by-attribute b5e9ba1e00

Add "changed" check and don't affect hidden faces 3240bd549a

Hans Goudey merged commit 3d236bc858 into blender-v4.0-release

2023-10-17 09:25:00 +02:00

Hans Goudey referenced this issue from a commit

2023-10-17 09:25:00 +02:00

Mesh: Add operator to select elements based on boolean attribute

Hans Goudey deleted branch mesh-edit-select-by-attribute

2023-10-17 09:25:02 +02:00

Sign in to join this conversation.