blender
/
blender
135
420
Fork 603
Code Issues 6.3k Pull Requests 757 Projects 19 Wiki Activity

EEVEE-Next: New shadow settings #113980

Merged
Miguel Pozo merged 20 commits from pragma37/blender:pull-eevee-shadow-settings into main 2023-11-06 15:45:10 +01:00
Conversation 1 Commits 20 Files Changed 15 +1 -6
2 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 3068b641c3 - Show all commits

2
scripts/startup/bl_ui/properties_object.py
View File

@ -393,7 +393,7 @@ class OBJECT_PT_visibility(ObjectButtonsPanel, Panel):
if ob.type in {'MESH', 'CURVE', 'SURFACE', 'META', 'FONT', 'CURVES', 'POINTCLOUD', 'VOLUME'}:
layout.separator()
col = layout.column(heading="Ray Visibility")
col.prop(ob, "hide_shadow", text="Shadow", toggle=False, invert_checkbox=True)
col.prop(ob, "visible_shadow", text="Shadow", toggle=False)
fclem marked this conversation as resolved
Clément Foucault commented 2023-10-30 14:11:28 +01:00
Review
Copy Link

Use hide_shadow for consistency with the other visibility options for now.

Use `hide_shadow` for consistency with the other visibility options for now.
Miguel Pozo commented 2023-10-30 15:58:13 +01:00
Review
Copy Link

I think having 2 different Python properties that change the same flag is going to be quite confusing for Python users.

I think having 2 different Python properties that change the same flag is going to be quite confusing for Python users.
Clément Foucault commented 2023-10-30 16:02:44 +01:00
Review
Copy Link

Nevermind, I replied to this before we decided to unify the setting first. So use cycles naming convention for now. We can still create an alias if we decide to port it later.

I think having 2 different Python properties that change the same flag is going to be quite confusing for Python users.

We can do that for compatibility reasons.

Nevermind, I replied to this before we decided to unify the setting first. So use cycles naming convention for now. We can still create an alias if we decide to port it later. > I think having 2 different Python properties that change the same flag is going to be quite confusing for Python users. We can do that for compatibility reasons.
if ob.type in {'MESH', 'CURVE', 'SURFACE', 'META', 'FONT', 'CURVES', 'POINTCLOUD', 'VOLUME', 'LIGHT'}:
layout.separator()

5
source/blender/makesrna/intern/rna_object.cc
View File

@ -2909,11 +2909,6 @@ static void rna_def_object_visibility(StructRNA *srna)
RNA_def_property_ui_icon(prop, ICON_RESTRICT_RENDER_OFF, -1);
RNA_def_property_update(prop, NC_OBJECT | ND_DRAW, "rna_Object_hide_update");
prop = RNA_def_property(srna, "hide_shadow", PROP_BOOLEAN, PROP_NONE);
RNA_def_property_boolean_sdna(prop, nullptr, "visibility_flag", OB_HIDE_SHADOW);
RNA_def_property_ui_text(prop, "Disable Shadow casting", "Globally disable Shadow casting");
RNA_def_property_update(prop, NC_OBJECT | ND_DRAW, "rna_Object_internal_update_draw");
prop = RNA_def_property(srna, "hide_probe_volume", PROP_BOOLEAN, PROP_NONE);
RNA_def_property_boolean_sdna(prop, nullptr, "visibility_flag", OB_HIDE_PROBE_VOLUME);
RNA_def_property_ui_text(prop, "Disable in Volume Probes", "Globally disable in volume probes");