blender
/
blender
136
407
Fork 591
Code Issues 6.3k Pull Requests 776 Projects 19 Wiki Activity

Fix memory leak when renaming node group sockets/panels #114083

Merged
Julian Eisel merged 1 commits from JulianEisel/blender:temp-fix-node-group-view-rename-memleak into blender-v4.0-release 2023-10-24 11:48:17 +02:00
Conversation 0 Commits 1 Files Changed 1 +4
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source/blender/editors/interface/interface_template_node_tree_interface.cc
View File

@ -151,6 +151,8 @@ class NodeSocketViewItem : public BasicTreeViewItem {
}
bool rename(const bContext &C, StringRefNull new_name) override
{
MEM_SAFE_FREE(socket_.name);
socket_.name = BLI_strdup(new_name.c_str());
nodetree_.tree_interface.tag_items_changed();
ED_node_tree_propagate_change(&C, CTX_data_main(&C), &nodetree_);
@ -208,6 +210,8 @@ class NodePanelViewItem : public BasicTreeViewItem {
}
bool rename(const bContext &C, StringRefNull new_name) override
{
MEM_SAFE_FREE(panel_.name);
panel_.name = BLI_strdup(new_name.c_str());
nodetree_.tree_interface.tag_items_changed();
ED_node_tree_propagate_change(&C, CTX_data_main(&C), &nodetree_);