UI Code Quality: Rename UI_ACTIVE button flag to UI_HOVER #114113

Merged
Julian Eisel merged 5 commits from JulianEisel/blender:temp-rename-uibut-active-flag into main 2023-10-25 18:36:38 +02:00

5 Commits

Author SHA1 Message Date
Julian Eisel 5ce98f8323 Improve comments 2023-10-25 18:35:37 +02:00
Julian Eisel 7f33f71186 Merge branch 'main' into temp-rename-uibut-active-flag 2023-10-25 18:18:30 +02:00
Julian Eisel 244c44468c Rename `UI_BUT_ACTIVE_LEFT`/`UI_BUT_ACTIVE_RIGHT` too 2023-10-24 18:30:04 +02:00
Julian Eisel 1e71bacfe6 Back to `UI_HOVER`, update comment 2023-10-24 18:19:45 +02:00
Julian Eisel 9e8e03430a UI Code Quality: Rename `UI_ACTIVE` button flag to `UI_HOVER_FOCUS`
Calling this state "Active" has been confusing for a long time, it's not
clear that this is essentially a mouse hover state. It's especially easy
to confuse this with the "Select" state (`UI_SELECT` button flag), which
is used to indicate a pushed button state (and should be renamed too).

The term "Hover Focus" was chosen because it both reflects how it
indicates the hovered state, but also the fact that such buttons can
receive input like shortcut events. A comment is added explaining this
state flag.

See #112160.
2023-10-24 17:09:54 +02:00