blender
/
blender
135
420
Fork 603
Code Issues 6.3k Pull Requests 753 Projects 19 Wiki Activity

Anim: Unit tests for inserting keyframes #114465

Merged
Christoph Lendenfeld merged 9 commits from ChrisLend/blender:keyframing_unittests into main 2023-11-07 16:17:41 +01:00
Conversation 0 Commits 9 Files Changed 2 +12 -4
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 689be11fe4 - Show all commits

16
tests/python/bl_animation_keyframing.py
View File

@ -178,17 +178,25 @@ class CycleAwareKeyingTest(AbstractKeyframingTest, unittest.TestCase):
bpy.context.scene.frame_set(5)
bpy.ops.anim.keyframe_insert_by_name(type="Location")
# Will be mapped to frame 3
bpy.context.scene.frame_set(22)
bpy.ops.anim.keyframe_insert_by_name(type="Location")
# check that only location keys have been created.
# Will be mapped to frame 9
bpy.context.scene.frame_set(-10)
bpy.ops.anim.keyframe_insert_by_name(type="Location")
nathanvegdahl marked this conversation as resolved Outdated
Nathan Vegdahl commented 2023-11-07 12:06:08 +01:00
Outdated
Review
Copy Link

I think it would be better to test for the exact frame values you expect here. Additionally, it might be good to add a key at a frame earlier than the action frame range to make sure that gets mapped back in properly as well.

I think it would be better to test for the exact frame values you expect here. Additionally, it might be good to add a key at a frame earlier than the action frame range to make sure that gets mapped back in properly as well.
Christoph Lendenfeld commented 2023-11-07 12:54:01 +01:00
Outdated
Review
Copy Link

Good point, done that :)

Good point, done that :)
# Check that only location keys have been created.
self.assertTrue(_fcurve_paths_match(action.fcurves, ["location"]))
expected_keys = [1, 3, 5, 9, 20]
for fcurve in action.fcurves:
self.assertEqual(len(fcurve.keyframe_points), 4)
self.assertEqual(len(fcurve.keyframe_points), len(expected_keys))
key_index = 0
for key in fcurve.keyframe_points:
# No keyframe should be outside the cyclic range.
self.assertLessEqual(key.co.x, cyclic_range_end)
self.assertEqual(key.co.x, expected_keys[key_index])
key_index += 1
# All fcurves should have a cycles modifier.
self.assertTrue(fcurve.modifiers[0].type == "CYCLES")