VSE: Fix various "off by half a pixel" issues in image transform #116628

Merged
Aras Pranckevicius merged 2 commits from aras_p/blender:vse-fix-filter into main 2024-01-08 16:51:45 +01:00

2 Commits

Author SHA1 Message Date
Aras Pranckevicius ba8e0e0ea2 ImBuf: fix off by half a pixel issues in IMB_transform
buildbot/vexp-code-patch-lint Build done. Details
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-darwin-x86_64 Build done. Details
buildbot/vexp-code-patch-darwin-arm64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
IMB_transform code was not properly doing mapping between pixel and
texel space. This caused for example bilinear with 0.5 scale
not properly averaging each 2x2 source image pixel, but rather just
picking one out of 2x2 source pixels. The subsampling case setup
code had a sign error too.
2023-12-29 13:25:07 +02:00
Aras Pranckevicius a4be6be15d ImBuf: simplify TransformUserData init math
Adding X and then subtracting X, or multiplying by Y and then dividing
by Y do kinda cancel out, yo.
2023-12-29 10:39:39 +02:00