blender
/
blender
136
407
Fork 589
Code Issues 6.3k Pull Requests 779 Projects 19 Wiki Activity

Anim: Change text for keyframe with keyingset operator #117508

Closed
Christoph Lendenfeld wants to merge 6 commits from ChrisLend/blender:rename_to_apply_keyingset into main
pull from: ChrisLend/blender:rename_to_apply_keyingset
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 2 Commits 6 Files Changed 2 +4 -5
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
scripts/startup/bl_ui/space_view3d.py
View File

@ -2772,9 +2772,9 @@ class VIEW3D_MT_object_animation(Menu):
layout = self.layout
layout.operator("anim.keyframe_insert", text="Insert Keyframe")
layout.operator("anim.keyframe_insert_menu", text="Insert Keyframe with Keying Set").always_prompt = True
layout.operator("anim.keyframe_delete_v3d", text="Delete Keyframes...")
layout.operator("anim.keyframe_clear_v3d", text="Clear Keyframes...")
layout.operator("anim.keyframe_insert_menu", text="Apply Keying Set").always_prompt = True
layout.operator("anim.keying_set_active_set", text="Change Keying Set...")
layout.separator()
@ -3037,7 +3037,7 @@ class VIEW3D_MT_object_context_menu(Menu):
layout.separator()
layout.operator("anim.keyframe_insert", text="Insert Keyframe")
layout.operator("anim.keyframe_insert_menu", text="Insert Keyframe with Keying Set").always_prompt = True
layout.operator("anim.keyframe_insert_menu", text="Apply Keying Set").always_prompt = True
layout.separator()
@ -4155,7 +4155,7 @@ class VIEW3D_MT_pose_context_menu(Menu):
layout.operator_context = 'INVOKE_REGION_WIN'
layout.operator("anim.keyframe_insert", text="Insert Keyframe")
layout.operator("anim.keyframe_insert_menu", text="Insert Keyframe with Keying Set").always_prompt = True
layout.operator("anim.keyframe_insert_menu", text="Apply Keying Set").always_prompt = True
layout.separator()

3
source/blender/editors/animation/keyframing.cc
View File

@ -503,8 +503,7 @@ void ANIM_OT_keyframe_insert_menu(wmOperatorType *ot)
/* identifiers */
ot->name = "Insert Keyframe Menu";
ot->idname = "ANIM_OT_keyframe_insert_menu";
ot->description =
"Insert Keyframes for specified Keying Set, with menu of available Keying Sets if undefined";
ot->description = "Insert Keyframes by applying the specified Keying Set";
Nate Rupsis commented 2024-01-25 16:31:50 +01:00
Outdated
Review
Copy Link

(pedantic)
Seems like we're a little across the board with capitalizing "Keying Set". Should "Keyframes" also be capital here?

(pedantic) Seems like we're a little across the board with capitalizing "Keying Set". Should "Keyframes" also be capital here?
👍 1
Christoph Lendenfeld commented 2024-01-25 16:38:57 +01:00
Outdated
Review
Copy Link

thanks for catching that right away. Definitely not pedantic

thanks for catching that right away. Definitely not pedantic
👍 1
/* callbacks */
ot->invoke = insert_key_menu_invoke;