blender
/
blender
136
407
Fork 589
Code Issues 6.3k Pull Requests 778 Projects 19 Wiki Activity

Curves: Add simplify_curve_attribute function #118560

Merged
Falk David merged 17 commits from filedescriptor/blender:curves-resample-adaptive into main 2024-03-26 15:28:22 +01:00
Conversation 11 Commits 17 Files Changed 3 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit ba0261deb2 - Show all commits

2
source/blender/geometry/intern/simplify_curves.cc
View File

@ -145,7 +145,7 @@ IndexMask simplify_curve_attribute(const Span<float3> positions,
std::is_same_v<T, float3>)
{
curve_simplifiy(points,
filedescriptor marked this conversation as resolved Outdated
Hans Goudey commented 2024-03-26 14:03:50 +01:00
Outdated
Review
Copy Link

It seems clearer to slice all the input data so it's all local to the curve in curve_simplifiy

It seems clearer to slice all the input data so it's all local to the curve in `curve_simplifiy`
positions.slice(points),
positions,
cyclic[curve_i],
epsilon,
attribute_data.typed<T>(),