blender/blender
172
532
Fork 807
Code Issues 6.5k Pull Requests 973 Projects 21 Wiki Activity

UI: Correct Splash RGB Image Corner Rounding #119473

Merged
Harley Acheson merged 2 commits from Harley/blender:SplashCorners into blender-v4.1-release 2024-03-14 17:22:30 +01:00
Conversation 0 Commits 2 Files Changed 1 +1
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
source/blender/windowmanager/intern/wm_splash_screen.cc
View File

@ -158,6 +158,7 @@ static ImBuf *wm_block_splash_image(int width, int *r_height)
}
if (ibuf) {
ibuf->planes = 32; /* The image might not have an alpha channel. */
Harley marked this conversation as resolved Outdated
Brecht Van Lommel commented 2024-03-14 16:44:46 +01:00
Outdated
Review
Copy Link

ibuf->channels only applies to the float buffer, it should not be used here.

I think you can just do ibuf->planes = 32; without any checks.

`ibuf->channels` only applies to the float buffer, it should not be used here. I think you can just do `ibuf->planes = 32;` without any checks.
height = (width * ibuf->y) / ibuf->x;
if (width != ibuf->x || height != ibuf->y) {
IMB_scaleImBuf(ibuf, width, height);