blender
/
blender
135
425
Fork 607
Code Issues 6.3k Pull Requests 774 Projects 19 Wiki Activity

Fix #119275: Update Sidebar Values with Voxel Size Changes #119646

Merged
Harley Acheson merged 2 commits from Hik/blender:fix/missing-voxel-size-notifier into main 2024-03-19 20:57:36 +01:00
Conversation 0 Commits 2 Files Changed 1 +1
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
source/blender/editors/object/object_remesh.cc
View File

@ -383,6 +383,7 @@ static int voxel_size_edit_modal(bContext *C, wmOperator *op, const wmEvent *eve
MEM_freeN(op->customdata);
ED_region_tag_redraw(region);
ED_workspace_status_text(C, nullptr);
WM_event_add_notifier(C, NC_GEOM | ND_DATA, nullptr);
Pratik Borhade commented 2024-03-19 12:43:15 +01:00
Outdated
Review
Copy Link

Not sure if reference is required in this case (works even without it)

Not sure if reference is required in this case (works even without it)
Hik commented 2024-03-19 16:31:07 +01:00
Outdated
Review
Copy Link

Indeed, it works even without it! I ended up passing the reference because I thought it would be desired to specify the data when we have access to it. Is it the common practice to only forward the reference when needed instead?

Indeed, it works even without it! I ended up passing the reference because I thought it would be desired to specify the data when we have access to it. Is it the common practice to only forward the reference when needed instead?
Harley Acheson commented 2024-03-19 18:19:21 +01:00
Outdated
Review
Copy Link

Yes, unless that data is examined by the recipient, best to not pass it. Makes for a simpler read.

Yes, unless that data is examined by the recipient, best to not pass it. Makes for a simpler read.
Hik commented 2024-03-19 18:58:49 +01:00
Outdated
Review
Copy Link

Got it! I will make the adjustment :)

Got it! I will make the adjustment :)
return OPERATOR_FINISHED;
}