blender/blender
149
475
Fork 705
Code Issues 6.7k Pull Requests 897 Projects 18 Wiki Activity

Anim: implement 3D viewport keyframing functionality for the Animation data-block #120428

Closed
Nathan Vegdahl wants to merge 21 commits from nathanvegdahl/blender:baklava_keyframing into main
pull from: nathanvegdahl/blender:baklava_keyframing
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 3 Commits 21 Files Changed 15 +11
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit bf550b3d02 - Show all commits

11
source/blender/animrig/intern/keyframing.cc
View File

@ -98,6 +98,17 @@ void CombinedKeyingResult::generate_reports(ReportList *reports)
}
Vector<std::string> errors;
nathanvegdahl marked this conversation as resolved
Sybren A. Stüvel commented 2024-05-06 17:56:08 +02:00
Review
Copy Link

Check the discussion about this in #animation-module. We'll have to simplify these messages to just a single string that covers both singular & plural.

"Could not insert {:d} key(s) for unknown reasons."

Check the discussion about this in `#animation-module`. We'll have to simplify these messages to just a single string that covers both singular & plural. `"Could not insert {:d} key(s) for unknown reasons."`
👍 1
Nathan Vegdahl commented 2024-05-07 16:13:09 +02:00
Review
Copy Link

Got it. If that gets addressed for the other report messages in main first, then I'll update these ones as well before merging. Otherwise I think it makes sense to merge as-is, and then they can all be changed together.

Got it. If that gets addressed for the other report messages in main first, then I'll update these ones as well before merging. Otherwise I think it makes sense to merge as-is, and then they can all be changed together.
if (this->get_count(SingleKeyingResult::GENERIC_FAILURE) > 0) {
const int error_count = this->get_count(SingleKeyingResult::GENERIC_FAILURE);
if (error_count == 1) {
errors.append(RPT_("Could not insert one key for unknown reasons."));
}
else {
errors.append(
fmt::format(RPT_("Could not insert {:d} keys for unknown reasons."), error_count));
}
}
if (this->get_count(SingleKeyingResult::CANNOT_CREATE_FCURVE) > 0) {
const int error_count = this->get_count(SingleKeyingResult::CANNOT_CREATE_FCURVE);
if (error_count == 1) {