blender
/
blender
135
420
Fork 603
Code Issues 6.3k Pull Requests 754 Projects 19 Wiki Activity

UI: Add title to tree view context menus #120694

Merged
Pratik Borhade merged 9 commits from PratikPB2123/blender:bcol-ctxmenu-header into main 2024-06-05 11:28:55 +02:00
Conversation 12 Commits 9 Files Changed 12 +3 -3
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 297d4decb0 - Show all commits

6
source/blender/editors/interface/interface.cc
View File

@ -6438,11 +6438,11 @@ std::string UI_but_string_get_label(uiBut &but)
std::string UI_but_context_menu_title_from_button(uiBut &but)
Julian Eisel commented 2024-05-03 16:19:41 +02:00
Review
Copy Link

but can be const.

`but` can be `const`.
Pratik Borhade commented 2024-05-04 11:11:36 +02:00
Review
Copy Link

If we do this, we will also need to change "button parameter -> const" of few other functions. Example: UI_but_string_get_label, UI_but_string_get_rna_label, UI_but_operator_ptr_ensure and possibly few more.
Maybe best to do it outside of this PR to avoid the noise? 😅

or use const_cast?

If we do this, we will also need to change "button parameter -> const" of few other functions. Example: `UI_but_string_get_label`, `UI_but_string_get_rna_label`, `UI_but_operator_ptr_ensure` and possibly few more. Maybe best to do it outside of this PR to avoid the noise? 😅 or use `const_cast`?
{
if (but.type == UI_BTYPE_VIEW_ITEM) {
const uiButViewItem *view_item_but = static_cast<uiButViewItem *>(&but);
if (view_item_but == nullptr) {
const uiButViewItem &view_item_but = static_cast<const uiButViewItem &>(but);
Julian Eisel commented 2024-05-03 16:20:19 +02:00
Outdated
Review
Copy Link
const uiButViewItem &view_item_but = static_cast<const uiButViewItem &>(but);
```cpp const uiButViewItem &view_item_but = static_cast<const uiButViewItem &>(but); ```
if (view_item_but.view_item == nullptr) {
Julian Eisel commented 2024-05-03 16:22:03 +02:00
Outdated
Review
Copy Link

view_item should be null-checked. Can return an empty string in that case I guess.

`view_item` should be null-checked. Can return an empty string in that case I guess.
return "";
}
blender::ui::AbstractView &tree_view = view_item_but->view_item->get_view();
blender::ui::AbstractView &tree_view = view_item_but.view_item->get_view();
Julian Eisel commented 2024-06-04 18:29:37 +02:00
Outdated
Review
Copy Link

const

`const`
return IFACE_(tree_view.get_context_menu_title().c_str());
}
return UI_but_string_get_label(but);