IMB: Cleanup timecode options #121001

Merged
Richard Antalik merged 15 commits from iss/blender:simplify-timecode into main 2024-05-06 17:57:07 +02:00

15 Commits

Author SHA1 Message Date
Richard Antalik 7fd5cb6153 Whitespace 2024-05-06 17:48:02 +02:00
Richard Antalik 62c4a6e9ef Merge branch 'main' into simplify-timecode 2024-05-06 17:46:05 +02:00
Richard Antalik 54bc504450 Merge branch 'main' into simplify-timecode 2024-05-03 15:41:21 +02:00
Richard Antalik 26eb64ddb6 Address review 2024-05-02 12:49:49 +02:00
Richard Antalik deb02f7191 Address review 2024-05-02 10:30:23 +02:00
Richard Antalik 59e4e33207 Sequencer naimg is different from movieclip 2024-04-29 09:35:57 +02:00
Richard Antalik 7c1a9e64a8 Fix array index 2024-04-29 09:34:14 +02:00
Richard Antalik f9ff6a6c48 Fix incomplete refactoring 2024-04-29 09:29:06 +02:00
Richard Antalik c770dcd13b I guess subversion 23 is enough? 2024-04-29 09:04:28 +02:00
Richard Antalik 7884be3931 Merge branch 'main' into simplify-timecode 2024-04-29 09:03:15 +02:00
Richard Antalik 794aac3096 Merge branch 'main' into simplify-timecode 2024-04-29 09:01:00 +02:00
Richard Antalik 5868d107cd Revert naming changes 2024-04-29 08:58:39 +02:00
Richard Antalik a92a12c82b Use better naming, clarify usage bit more.
buildbot/vexp-code-patch-lint Build done. Details
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-darwin-x86_64 Build done. Details
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-darwin-arm64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
2024-04-25 00:53:08 +02:00
Richard Antalik 8f0780db31 Merge branch 'main' into simplify-timecode 2024-04-25 00:05:07 +02:00
Richard Antalik 2ea7346187 IMB: Cleanup timecode options
Remove options that are duplicate, rename remaining options, so these
represent to how timecodes are actually used.

Timecodes in Blender have pretty much nothing in common with more widely
known term "timecode". This confused users (and developers).
There were 5 options of which 3 were exactly same. This commit leaves
user with 3 options:
 - Play movie normally - "Use Movie Timestamps" in menu
 - Ensure, that no frame is duplicated or skipped - "No Gaps Playback"
 - Do not use timecodes - "None"

Description of these options now describes, what these do, and
implicitly, when they should be used.

Perhaps the intention was, that if your device uses record run
or free run timecode, you could pick this option and it would just
work. But this fact and the description of these options is just
misleading.

----

Perhaps this could be more verbose in description, For example "Use Movie Timestamps" should be used if there are issues with seeking.

The DNA naming could be more precise as well - IMB_TC_INVERSE_MAPPING means, that timestamp -> frame table is generated by info from ffmpeg, we than use it as frame -> timestamp It could be called IMB_TC_USE_FRAME_PTS_MAP, but I think, that in some streams, instead of PTS, a binary offset is used. So inverse mapping is more general, but not telling much to person not knowing anything about this system.

The whole term Timecode could be renamed as well, at least in UI, so this is even less confusing
2024-04-24 02:33:48 +02:00