BogdanNagirniak
/
blender
forked from blender/blender
0
0
Fork 3
Code Pull Requests Activity

Changes to enable MacOS viewport. #70

Closed
Brian Savery (AMD) wants to merge 1 commits from BrianSavery/blender:mac_build into hydra-render
pull from: BrianSavery/blender:mac_build
merge into: BogdanNagirniak:hydra-render

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 1 Commits 1 Files Changed 3 +15 -10
Brian Savery (AMD) commented 2023-07-21 00:07:09 +02:00
Collaborator
Copy Link

With help from Apple, these changes are needed to enable the Storm viewport on MacOS.
Mainly this is setting the texture to either half or float depending on the buffer type.

With help from Apple, these changes are needed to enable the Storm viewport on MacOS. Mainly this is setting the texture to either half or float depending on the buffer type.
Brian Savery (AMD) added 1 commit 2023-07-21 00:07:21 +02:00
Brian Savery (AMD) requested review from Brecht Van Lommel 2023-07-21 00:07:55 +02:00
Brian Savery (AMD) requested review from Matt McLin 2023-07-21 00:08:03 +02:00
Brecht Van Lommel approved these changes 2023-07-21 13:40:18 +02:00
Bogdan Nagirniak requested changes 2023-07-23 22:20:55 +02:00
Bogdan Nagirniak left a comment
Owner
Copy Link

In Windows Viewport returns empty image for Storm delegate, commented what has to be reverted.

In Windows Viewport returns empty image for Storm delegate, commented what has to be reverted.
source/blender/render/hydra/viewport_engine.cc
@ -243,3 +250,1 @@
if ((bl_engine_->type->flag & RE_USE_GPU_CONTEXT) == 0) {
render_task_delegate_->set_renderer_aov(pxr::HdAovTokens->color);
}
render_task_delegate_->set_renderer_aov(pxr::HdAovTokens->color);
Bogdan Nagirniak commented 2023-07-23 22:19:54 +02:00
Owner
Copy Link

This has to be reverted, because it returns empty image in viewport.

This has to be reverted, because it returns empty image in viewport.
source/blender/render/hydra/viewport_engine.cc
@ -259,3 +263,1 @@
draw_texture_.set_buffer(render_task_delegate_->get_renderer_aov(pxr::HdAovTokens->color));
draw_texture_.draw(shader, view_settings.border[0], view_settings.border[1]);
}
draw_texture_.set_buffer(render_task_delegate_->get_renderer_aov(pxr::HdAovTokens->color));
Bogdan Nagirniak commented 2023-07-23 22:20:05 +02:00
Owner
Copy Link

This has to be reverted, because it returns empty image in viewport.

This has to be reverted, because it returns empty image in viewport.
Bogdan Nagirniak commented 2023-07-31 21:21:42 +02:00
Owner
Copy Link

Done in #82

Done in #82
Bogdan Nagirniak closed this pull request 2023-07-31 21:21:42 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Matt McLin
Brecht Van Lommel
Bogdan Nagirniak
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#70
No description provided.
Delete Branch "BrianSavery/blender:mac_build"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?