Jorijn de Graaf bonj
  • Joined on 2023-02-10
Jorijn de Graaf commented on pull request blender/blender#104599 2023-02-14 14:17:00 +01:00
#70267 Retopology Overlay

It's counter-intuitive, but dividing seems to be the right approach here. If we multiply by W, the effective offset changes in an undesirable way when zooming in or out. I don't really know how…

Jorijn de Graaf pushed to retopology-overlay at bonj/blender 2023-02-14 14:04:33 +01:00
22b25cc13f Use epsilon for retopology bias
Jorijn de Graaf commented on pull request blender/blender#104599 2023-02-14 14:00:14 +01:00
#70267 Retopology Overlay

Previously it was like this: overlay_uniform_color and overlay_depth_only use overlay_depth_only_vert.glsl Now it is like this: overlay_uniform_color uses overlay_uniform_color_vert.glsl, and…

Jorijn de Graaf commented on pull request blender/blender#104599 2023-02-14 13:43:04 +01:00
#70267 Retopology Overlay

That's a very large negative value. I could use FLT_EPSILON though, perhaps not as minimum for the property, but that I add it before sending the value to the shader, to make sure it's never 0…

Jorijn de Graaf commented on pull request blender/blender#104599 2023-02-14 02:53:57 +01:00
#70267 Retopology Overlay

This is necessary because the value is -1.0 when the checkbox is disabled. That is how the shader knows whether to use the regular face color or the retopology face color. Alternatively I could…

Jorijn de Graaf pushed to retopology-overlay at bonj/blender 2023-02-14 01:21:07 +01:00
06e2c9de91 Merge branch 'main' into retopology-overlay
0fa34aa0ec Cleanup: spelling in comments, reference enum types in doc-strings
e928dd300b Cleanup: format
dc46465490 Cleanup: use typed enum (eDirEntry_SelectFlag) where appropriate
1d7bf4f826 BLI_utildefines: add ^= operator to ENUM_OPERATORS macro
Compare 6 commits »
Jorijn de Graaf pushed to retopology-overlay at bonj/blender 2023-02-14 01:20:06 +01:00
27e9d081be Don't update View3D Shading on bias change
Jorijn de Graaf pushed to retopology-overlay at bonj/blender 2023-02-14 01:15:34 +01:00
c61f249388 Adjust retopology bias property
Jorijn de Graaf pushed to retopology-overlay at bonj/blender 2023-02-14 00:12:52 +01:00
fe0a6bb20a Lower opacity of default retopology color
517563b698 Use back face culling for retopology overlay
Compare 2 commits »
Jorijn de Graaf pushed to retopology-overlay at bonj/blender 2023-02-14 00:11:47 +01:00
2003c5311c Merge branch 'main' into retopology-overlay
bb9eb262d4 Revert "Cycles: Clean up the Principled Hair BSDF implementation"
1f615690e6 Cycles: Add support for CUDA 12
6a0b1eae8c Fix #104097: re-enable Cycles AMD Vega support
cb77865c21 Cycles: Clean up the Principled Hair BSDF implementation
Compare 23 commits »
Jorijn de Graaf commented on pull request blender/blender#104599 2023-02-13 13:47:33 +01:00
#70267 Retopology Overlay

Sorry about the force push, there were merge conflicts and I didn't know how else to fix it.

Jorijn de Graaf pushed to retopology-overlay at bonj/blender 2023-02-13 13:47:13 +01:00
cea8a25cc2 Fix ThemeSpace struct padding
Jorijn de Graaf pushed to retopology-overlay at bonj/blender 2023-02-13 13:34:12 +01:00
cd3ec56a76 Fix depth pass for retopology overlay
279e7df542 Allow retopology bias to be 0
95f8789f7e Fix retopology overlay in orthographic view
9cf223496b Replace Hidden Wire with Retopology
e78ef5f509 Add retopology bias to shaders
Compare 34 commits »
Jorijn de Graaf pushed to retopology-overlay at bonj/blender 2023-02-13 00:22:27 +01:00
0338a79f34 Fix depth pass for retopology overlay
Jorijn de Graaf pushed to retopology-overlay at bonj/blender 2023-02-12 16:49:53 +01:00
00faf4aa13 Merge branch 'main' into retopology-overlay
3f40962414 Cleanup: use sized int types for polyfill_2d
32149f8d7a Tests: add polyfill2d test to ensure the result has no zero area tris
91346755ce Cleanup: use '#' prefix for issues instead of 'T'
a02fa6c40d Cleanup: spelling in comments
Compare 9 commits »
Jorijn de Graaf commented on pull request blender/blender#104599 2023-02-12 00:32:51 +01:00
#70267 Retopology Overlay

Oh and another note: I think the depth only pass uses a mesh with modifiers that have "show in edit mode" enabled, while the overlay pass uses a mesh with modifiers that have "show on cage"…

Jorijn de Graaf commented on pull request blender/blender#104599 2023-02-12 00:29:28 +01:00
#70267 Retopology Overlay

It's quite difficult to tell front faces from back faces in retopology mode.

I have two proposed solutions:

  1. Use a different color for front and back (I was thinking blue and red).
  2. Cull…
Jorijn de Graaf commented on pull request blender/blender#104599 2023-02-11 19:46:35 +01:00
#70267 Retopology Overlay

Works great! I just have a one suggestion left.

IMO the Z-bias slider shouldn't be able to go all the way to 0 and turn the overlay off. Only the toggle should be able to disable the…

Jorijn de Graaf pushed to retopology-overlay at bonj/blender 2023-02-11 19:43:11 +01:00
14cee26ed5 Merge branch 'main' into retopology-overlay
085c854b2a Fix curves selection toggling
82867753cf Transform: Hide trackball gizmo while dragging
232e02282e Fix circular transform gizmo always displaying Global orientation
b9fa32cccd Fix #104587: 'Extrude To Cursor' snapping ignoring 'Target Selection'
Compare 6 commits »
Jorijn de Graaf pushed to retopology-overlay at bonj/blender 2023-02-11 17:05:25 +01:00
42b6200410 Allow retopology bias to be 0