Brecht Van Lommel brecht
  • Blender & Cycles developer

  • Joined on 2003-01-03
Brecht Van Lommel commented on issue blender/blender#123347 2024-06-18 15:24:57 +02:00
NormalMap-Node UV-Map bug?

If you're baking from one UV map to another, you need to make sure that both the input UV map and tangents and output UV map and tangents are matched correctly. So that's transferring the image.…

Brecht Van Lommel pushed to fix_osl_optix_stack_size at pmoursnv/blender 2024-06-18 15:15:56 +02:00
769bed2676 Fix stack size calculation for OSL pipeline
4093945e9c Cleanup: Use the correct license name
50a83d3e0b Fix: BLI_SUBPROCESS_SUPPORT check
6d375cf7f0 Fix: EEVEE: Wrong thickness for rotated objects
8014b9cbb4 Fix #123183: EEVEE: Optimize velocity geometry buffer
Compare 53 commits »
Brecht Van Lommel commented on pull request blender/blender#123341 2024-06-18 15:09:41 +02:00
Fix #123324: Improve Cycles camera bounding box size calculation

Thanks!

For the panorama case, I think we also want to replace nearclip by max_aperture_size + nearclip.

Brecht Van Lommel commented on issue blender/blender#123347 2024-06-18 14:08:28 +02:00
NormalMap-Node UV-Map bug?

Tangents are computed from UV maps, both in Blender and game engines.

Brecht Van Lommel commented on issue blender/blender#123347 2024-06-18 12:46:33 +02:00
NormalMap-Node UV-Map bug?

To specify which tangents you want to use. Ideally it would be simpler and users would not need to do specify this in two places, but the design is what it is at the moment.

Brecht Van Lommel commented on issue blender/blender#122584 2024-06-18 12:45:10 +02:00
OpenImageDenoise CUTLASS error after rendering image

@aafra Is there an estimated date for the final OIDN 2.3 release? It would be good to get a bit of user testing of that before we release Blender 4.2 with it.

Brecht Van Lommel commented on issue blender/blender#123347 2024-06-18 12:42:42 +02:00
NormalMap-Node UV-Map bug?

Evaluation of shader nodes is strictly left to right. That means the normal map node can't affect the UV map used for the image texture node that comes before it, which I think is what you are…

Brecht Van Lommel commented on pull request blender/blender#123341 2024-06-18 12:39:40 +02:00
Fix #123324: Improve Cycles camera bounding box size calculation

I think the fix should be in Camera::viewplane_bounds_get. We can make the bounds bigger to account for the near clipping and aperture. Something like this, but I have not tested or checked the…

Brecht Van Lommel closed issue blender/blender#123347 2024-06-18 12:23:23 +02:00
NormalMap-Node UV-Map bug?
Brecht Van Lommel commented on issue blender/blender#123347 2024-06-18 12:23:19 +02:00
NormalMap-Node UV-Map bug?

That's correct. To use the same UV map in the image texture and normal map nodes as mentioned in the docs, you need to connect a UV map node to the image texture node.

Brecht Van Lommel commented on pull request blender/blender#123290 2024-06-17 23:48:06 +02:00
WIP: MacOS arm_x64 library updates

We have documentation for this: https://developer.blender.org/docs/handbook/contributing/pull_requests/#rebasing-a-pull-request

But manually cherry-picking a few commits is about the same…

Brecht Van Lommel commented on pull request blender/blender#123337 2024-06-17 23:46:29 +02:00
UI: Add Color Temperature unit

Just want to note that Blackbody node is present in Geometry Nodes as well, so subtype should be probably changed to that as well

The implementation is shared, there's only one place that…

Brecht Van Lommel commented on pull request blender/blender#121050 2024-06-17 23:42:07 +02:00
Cycles: Linux Support for HIP-RT

I meant make install in the hiprt project. We can manually copy files from the dist folder too, it's not a big deal, just unusual for a cmake project not to have an install target where the target…

Brecht Van Lommel commented on pull request blender/blender#123278 2024-06-17 22:31:00 +02:00
Color management: Support white balance as part of the display transform

I agree it's better to read the scene linear colors directly when possible. eyedropper_color.cc implements this for the image and compositing node editors, and extending that to the 3D viewport…

Brecht Van Lommel commented on issue blender/blender#122779 2024-06-17 21:42:19 +02:00
Illegal address error with OptiX OSL with specific materials

I bisected it down to this OSL commit: 1956e83954

Unfortunately changing to the new fused…

Brecht Van Lommel commented on issue blender/blender#104061 2024-06-17 19:34:38 +02:00
Custom render engine is unable to create gpu context

@mano-wii @Jeroen-Bakker

I can't think of a much better solution than reverting d7f124f06f and adding checks in all GPU API functions.

If we auto create a GPU context in background mode, I…

Brecht Van Lommel commented on pull request blender/blender#123278 2024-06-17 19:21:12 +02:00
Color management: Support white balance as part of the display transform

It's a convention for the render properties. For two reasons:

  • It adds visual clutter for no good reason.
  • Animating most render properties is bad for frame to frame coherence.
Brecht Van Lommel commented on issue blender/blender#122800 2024-06-17 18:32:37 +02:00
USD MaterialX export missing textures in Storm

I posted a PR now.

It does not solve the pre-existing issue that when renaming is off, the same material applied to multiple meshes with different active UV map fails. That can be solved…