Brecht Van Lommel brecht
  • Blender & Cycles developer

  • Joined on 2003-01-03
Brecht Van Lommel closed pull request blender/blender#120034 2024-05-21 18:14:45 +02:00
Refactor: UI changes for collection export presets
Brecht Van Lommel commented on pull request blender/blender#120034 2024-05-21 18:14:42 +02:00
Refactor: UI changes for collection export presets

Landed as part of 509a7870c3570cbf8496bcee0c94cdc1e9e41df5.

Brecht Van Lommel commented on pull request blender/blender#122048 2024-05-21 17:42:25 +02:00
Fix #70036: Fixed animation playback scaling

I think it's better to call this right after GHOST_CreateSystem, to match the regular Blender code. I'll make that change when committing.

Brecht Van Lommel pushed to lib-asset-editable at brecht/blender 2024-05-21 17:41:18 +02:00
d6ce7ff822 Libraries: Support editing linked datablocks from some libraries
Brecht Van Lommel commented on pull request blender/blender#119224 2024-05-21 17:40:16 +02:00
Fix #114515: Cycles: Numerical precision issues in triangle light sampling

For commits that include test files, I commit to the test data repo, and then amend the change into the blender repo commit and push manually.

But really it doesn't matter. Committing the test…

Brecht Van Lommel commented on pull request blender/blender#114545 2024-05-21 13:14:16 +02:00
The SLIM UV unwrap algorithm implementation for Blender 4.x

@Gangneron Copyright years do not have to be updated to the latest. Adding some missing Blender Authors is good though. https://developer.blender.org/docs/handbook/guidelines/license_headers/

Brecht Van Lommel commented on pull request blender/blender#114545 2024-05-21 13:13:00 +02:00
The SLIM UV unwrap algorithm implementation for Blender 4.x

Has a final decision to change the naming like this already been made? Should I implement it?

Yes, you can make the changes.

Brecht Van Lommel pushed to lib-asset-editable at brecht/blender 2024-05-21 13:03:46 +02:00
0471b7d2c3 Libraries: Support editing linked datablocks from some libraries
6969701b20 RNA: Better enforce rules about pointers between datablocks
8d8904b99e Refactor: Make BKE_libblock_rename support renaming linked IDs
37b10f8066 Refactor: Support library reloading without active scene pointer
a81fc5ecd0 Refactor: Add function to find ID with given name and library filepath
Compare 87 commits »
Brecht Van Lommel commented on pull request blender/blender#121920 2024-05-21 12:33:05 +02:00
Libraries: Support editing linked datablocks from some libraries

I think there should also be a bulletpoint in the commit message regarding undo behavior? I.e. that changes done to these new editable linked IDs are not undoable at all currently (unless I am…

Brecht Van Lommel pushed to lib-asset-editable at brecht/blender 2024-05-21 12:32:56 +02:00
bb49445428 Address comments
Brecht Van Lommel commented on issue blender/blender#121003 2024-05-21 11:35:05 +02:00
OPTIX_ERROR_INVALID_VALUE

@LukasStockner Looking at this in latest main, I noticed that thin film support is missing for OSL?

WARNING: attempting to set nonexistent parameter: ThinFilmThickness
WARNING:…
Brecht Van Lommel closed issue blender/blender#121969 2024-05-21 11:15:17 +02:00
Noise Texture no longer generates random value Once Coordinates beyond 10^5, this limit is higher for other textures
Brecht Van Lommel commented on issue blender/blender#121969 2024-05-21 11:15:13 +02:00
Noise Texture no longer generates random value Once Coordinates beyond 10^5, this limit is higher for other textures

It's indeed a known limitation due to numerical precision.

Brecht Van Lommel pushed to extensions-single-install-op at brecht/blender 2024-05-17 21:35:13 +02:00
7b88774d6f Extensions: Install From Disk operator handling both legacy and new
Brecht Van Lommel commented on pull request blender/blender#121926 2024-05-17 21:30:59 +02:00
Extensions: Install From Disk operator handling both legacy and new

This doesn't properly propagate reports. Not sure if there is some way of doing it in the API or if the operator would need to be refactored to be a function.