Brecht Van Lommel brecht
  • Blender & Cycles developer

  • Joined on 2003-01-03
Brecht Van Lommel commented on pull request blender/blender#121597 2024-05-15 19:48:44 +02:00
Brush Assets: Store editable brush assets in global main again

Now only support linking to other linked datablocks, at least for all the cases I found that affect brush assets. Mainly affects ID template and operators like new texture.

I restricted the…

Brecht Van Lommel pushed to same-main at brecht/blender 2024-05-15 19:48:17 +02:00
a1ead99c81 Brush Assets: Set asset weak reference from brush datablock pointer
6ea1fa3594 Brush Asset: Don't link from linked to local datablocks
066f4dfa29 Brush Assets: Preserve editable assets in new blend file
Compare 3 commits »
Brecht Van Lommel pushed to same-main at brecht/blender 2024-05-15 19:35:39 +02:00
4a7c07bffd Brush Assets: Set asset weak reference from brush datablock pointer
2e9c986895 Brush Asset: Don't link from linked to local datablocks
468ab87910 Brush Assets: Preserve editable assets in new blend file
39f41088a5 Brush Assets: Store editable brush assets in global main again
617037cd52 Refactor: Replace ID_IS_LINKED by !ID_IS_EDITABLE
Compare 95 commits »
Brecht Van Lommel created pull request blender/blender#121838 2024-05-15 19:28:49 +02:00
Refactor: Replace ID_IS_LINKED by !ID_IS_EDITABLE
Brecht Van Lommel pushed to is-editable at brecht/blender 2024-05-15 19:26:50 +02:00
4207ba76a8 Refactor: Replace ID_IS_LINKED by !ID_IS_EDITABLE
ad18fe673e Cleanup: Correct capitalization in comment
1cdc76ea41 Cleanup: Sculpt: Remove unused automasking function
1c1efb0a14 Cleanup: Sculpt: Move automasking functions to proper file
b8e419ba1e Cleanup: Sculpt: Use C++ types for orig vert data
Compare 10 commits »
Brecht Van Lommel created branch is-editable in brecht/blender 2024-05-15 19:26:50 +02:00
Brecht Van Lommel commented on pull request blender/blender#121597 2024-05-15 17:07:57 +02:00
Brush Assets: Store editable brush assets in global main again

Indeed, comment can just be removed.

Brecht Van Lommel commented on pull request blender/blender#121597 2024-05-15 17:05:39 +02:00
Brush Assets: Store editable brush assets in global main again

This was just restoring some code from main, fixed there: ad18fe673e57b891eb3f9e4d08c3915c64a23675

Brecht Van Lommel pushed to main at blender/blender 2024-05-15 17:05:16 +02:00
ad18fe673e Cleanup: Correct capitalization in comment
Brecht Van Lommel commented on pull request blender/blender#121597 2024-05-15 16:58:54 +02:00
Brush Assets: Store editable brush assets in global main again

I don't think it's needed. I consider that tag a cached value to avoid file access in some operator poll functions, not something that Python code needs to access.

Brecht Van Lommel commented on pull request blender/blender#121597 2024-05-15 16:53:55 +02:00
Brush Assets: Store editable brush assets in global main again

I think the general direction of this change is fine.

I have one big concern with current code: it seems to imply that these new linked 'editable' IDs can use local IDs. This is currently…

Brecht Van Lommel commented on pull request infrastructure/gitea-custom#7 2024-05-15 16:10:31 +02:00
Fix: Swap order of "Comment and Close"

I've put this as a commit in our Gitea fork now. 479d52dabf

That way we avoid having to maintain a copy of the locale…

Brecht Van Lommel closed pull request infrastructure/gitea-custom#7 2024-05-15 16:10:31 +02:00
Fix: Swap order of "Comment and Close"
Brecht Van Lommel commented on pull request blender/blender#121804 2024-05-15 14:53:04 +02:00
Cycles: Use blender's use_shadow RNA property

Can we move use_shadow to the light base class in RNA, so that this can change from BL::PointLight to BL::Light?

Brecht Van Lommel commented on pull request blender/blender#121816 2024-05-15 14:48:46 +02:00
Libs: Enable threads support for FFTW library

This will need changes in build_files/cmake/platform/platform_win32.cmake and source/creator/CMakeLists.txt as well. Though @LazyDodo usually does them.

Brecht Van Lommel pushed to main at infrastructure/blender-devops 2024-05-14 17:57:22 +02:00
2b7f1c8980 Fix: Windows store builder does not deduplicate MSIX files
4274f79382 Cleanup: Formatting
Compare 2 commits »
Brecht Van Lommel opened issue infrastructure/blender-projects-platform#80 2024-05-14 11:48:38 +02:00
Move to single public devops repo