infrastructure/gitea-custom
1
2
Fork 5
Code Pull Requests 1 Activity

Fix: Swap order of "Comment and Close" #7

Closed
Ray molenkamp wants to merge 1 commits from LazyDodo/gitea-custom:tmp_comment_button_fix into main
pull from: LazyDodo/gitea-custom:tmp_comment_button_fix
merge into: infrastructure:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 3 Commits 1 Files Changed 2 +3692
Ray molenkamp commented 2024-04-04 15:51:36 +02:00
First-time contributor
Copy Link

People keep accidentally closing tickets only to re-open them right
away, I suspect it's the left to right nature of the "Comment and
Close" button, people scan the toolbar left to right, first button
they see "Comment..." they go "yeah! that's it!" click it, then read
"and close" and go "oh.....no"

This PR changes the order to "Close with Comment" highlighting that
the closing of the ticket is the most important action being taken.

Ideally we'd be able to change a single locale string in the custom
folder but there is seemingly no fallback to the original file, a
complete locale_en-US.ini has to be supplied, I included a patch
to make upgrades to newer gitea versions easier in the future.

We eventually want to get upstream to fix this, but given humans
with squishy noodles are involved, probably better to try this out
locally first and prove this actually changes the user behaviour.

People keep accidentally closing tickets only to re-open them right away, I suspect it's the left to right nature of the "Comment and Close" button, people scan the toolbar left to right, first button they see "Comment..." they go "yeah! that's it!" click it, then read "and close" and go "oh.....no" This PR changes the order to "Close with Comment" highlighting that the closing of the ticket is the most important action being taken. Ideally we'd be able to change a single locale string in the custom folder but there is seemingly no fallback to the original file, a complete `locale_en-US.ini` has to be supplied, I included a patch to make upgrades to newer gitea versions easier in the future. We eventually want to get upstream to fix this, but given humans with squishy noodles are involved, probably better to try this out locally first and prove this actually changes the user behaviour.
👍 6 ❤️ 1
Ray molenkamp added 1 commit 2024-04-04 15:51:37 +02:00 
People keep accidentally closing tickets only to re-open them right
away, I suspect it's the left to right nature of the "Comment and
Close" button, people scan the toolbar left to right, first button
they see "Comment..." they go "yeah! that's it!" click it, then read
"and close" and go "oh.....no"

This PR changes the order to "Close with Comment" highlighting that
the closing of the ticket is the most important action being taken.

Ideally we'd be able to change a single translation in the custom
folder but there is seemingly no fallback to the original file, a
complete `locale_en-US.ini` has to be supplied, I included a patch
to make upgrades to newer gitea versions easier in the future.

We eventually want to get upstream to fix this, but given humans
with squishy noodles are involved, probably better to try this out
locally first and prove this actually changes the user behaviour.
Jesse Yurkovich commented 2024-04-04 20:01:38 +02:00
First-time contributor
Copy Link

Is there a way to brighten the "Comment" button next to it so that it doesn't still look dimmed once text has been typed?

Current:

gitea github
before typing gitea-0.png github-0.png
after typing, github brightens up gitea-1.png github-1.png
Is there a way to brighten the "Comment" button next to it so that it doesn't still look dimmed once text has been typed? Current: | | gitea | github | | --- | --- | --- | | before typing | ![gitea-0.png](/attachments/120e6292-9499-42cf-bcc2-23950b4e7865) | ![github-0.png](/attachments/6b7934c7-afdf-4fd3-8ee2-7251289dc248) | | after typing, github brightens up | ![gitea-1.png](/attachments/410cbcdc-a87c-4c33-9fed-3eb6a76cb453) | ![github-1.png](/attachments/43920f53-4c21-4c95-a120-56fb791bf7e6) |
gitea-0.png
3.3 KiB
github-0.png
3.7 KiB
gitea-1.png
3.9 KiB
github-1.png
4.7 KiB
Ray molenkamp commented 2024-04-04 20:54:10 +02:00
Author
First-time contributor
Copy Link

Not that i'm aware of, doesn't feel like the hardest modification to make, but still more than i currently have time for, so i'm gonna declare it out of scope for this PR.

Not that i'm aware of, doesn't feel like the hardest modification to make, but still more than i currently have time for, so i'm gonna declare it out of scope for this PR.
Sergey Sharybin reviewed 2024-05-15 10:31:10 +02:00
Sergey Sharybin left a comment
Owner
Copy Link

I think this is a great improvement on its own! Surely, we need to give more accent to the "Comment", and, especially "Approve" buttons, but that is probably better to handle separately anyway.

From the process perspective, it seems that it is expected that changes are done to develop branch, so that they are first tested on UATEST, and then merged to main.

I would also really like to avoid need to manually maintain the locales. It might be good for a short while, but it is unclear to me if you plan to take care of upstreaming it (also taking inti account your comment about time availiability).

I think this is a great improvement on its own! Surely, we need to give more accent to the "Comment", and, especially "Approve" buttons, but that is probably better to handle separately anyway. From the process perspective, it seems that it is expected that changes are done to `develop` branch, so that they are first tested on UATEST, and then merged to `main`. I would also really like to avoid need to manually maintain the locales. It might be good for a short while, but it is unclear to me if you plan to take care of upstreaming it (also taking inti account your comment about time availiability).
Brecht Van Lommel commented 2024-05-15 16:10:31 +02:00
Owner
Copy Link

I've put this as a commit in our Gitea fork now.
479d52dabf

That way we avoid having to maintain a copy of the locale file.

It should get deployed along with a Gitea 1.22 upgrade.

I've put this as a commit in our Gitea fork now. https://github.com/blender/gitea/commit/479d52dabf0c669de6c775fe81857c3f13812c83 That way we avoid having to maintain a copy of the locale file. It should get deployed along with a Gitea 1.22 upgrade.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/gitea-custom#7
No description provided.
Delete Branch "LazyDodo/gitea-custom:tmp_comment_button_fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?