Fix: Swap order of "Comment and Close" #7

Closed
Ray molenkamp wants to merge 1 commits from LazyDodo/gitea-custom:tmp_comment_button_fix into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

1 Commits

Author SHA1 Message Date
d272975ddf Fix: Swap order of "Comment and Close"
People keep accidentally closing tickets only to re-open them right
away, I suspect it's the left to right nature of the "Comment and
Close" button, people scan the toolbar left to right, first button
they see "Comment..." they go "yeah! that's it!" click it, then read
"and close" and go "oh.....no"

This PR changes the order to "Close with Comment" highlighting that
the closing of the ticket is the most important action being taken.

Ideally we'd be able to change a single translation in the custom
folder but there is seemingly no fallback to the original file, a
complete `locale_en-US.ini` has to be supplied, I included a patch
to make upgrades to newer gitea versions easier in the future.

We eventually want to get upstream to fix this, but given humans
with squishy noodles are involved, probably better to try this out
locally first and prove this actually changes the user behaviour.
2024-04-04 07:51:07 -06:00