david494
0 Followers · 0 Following
  • Joined on 2023-11-02
Repositories
1
 Projects Public Activity Starred Repositories
david494 created branch cycles-microfacet-precision in david494/blender 2024-08-05 20:36:58 +02:00
david494 commented on issue blender/blender#125750 2024-08-01 15:13:11 +02:00
Cycles: NaN pixels in Glossy and Transmissive Passes with roughness values near 0.0266

For these particular values the NaN can be avoided by rewriting that line as:

return alpha2 / (M_PI_F * sqr((1.0f - cos_NH2) + alpha2 * cos_NH2));

That looks like an overall improvement to…

david494 commented on pull request blender/blender#123035 2024-06-11 21:01:08 +02:00
Fix #122739: mix causes unnecessary evaluation when ints are used

Did the rebase to the release branch. Whoever wrote the contributor documentation did a stellar job! ❤️

david494 pushed to cycles-int-constant-fold at david494/blender 2024-06-11 20:56:38 +02:00
04134324ab unify function name with other setters
37e3685410 added missing integer setters, oops
12d8367453 Fix #122739: mix causes unnecessary evaluation when ints are used
6ea1d2131d Fix: PyAPI Doc: unexpected indentation error
354b1a5db9 Fix #122933: Enable Compositor OpenImageDenoise on Linux ARM64
Compare 46 commits »
david494 commented on issue blender/blender#122739 2024-06-11 17:49:26 +02:00
Material mix node input cause unnecessary evaluation when input mixing factor is int/bool

Thanks for the pointer! It came just at the right time while I was looking into this :)

david494 pushed to cycles-int-constant-fold at david494/blender 2024-06-10 23:37:09 +02:00
77907eb4fa unify function name with other setters
david494 pushed to cycles-int-constant-fold at david494/blender 2024-06-10 23:31:23 +02:00
6ef427940f added missing integer setters, oops
david494 created pull request blender/blender#123035 2024-06-10 21:04:07 +02:00
WIP: Fix #122739: mix causes unnecessary evaluation when ints are used
david494 created branch cycles-int-constant-fold in david494/blender 2024-06-10 21:01:17 +02:00
david494 pushed to cycles-int-constant-fold at david494/blender 2024-06-10 21:01:17 +02:00
78af5616a9 Fix #122739: mix causes unnecessary evaluation when ints are used
d573ee1e6c Sculpt: Use more specific update tags
7af444da86 Cleanup: Fix typo in comment
108c94f736 Cleanup: Reduce indentation, use const variables
8c8dcf8aaf Cleanup: Add comment to render job flag
Compare 10 commits »
david494 created pull request blender/blender#121348 2024-05-02 14:57:24 +02:00
Fix: unconnected direction input on ray portal bsdf is incorrect for OSL
david494 pushed to cycles-ray-portal-osl-fix at david494/blender 2024-05-02 14:44:44 +02:00
0f5f62775c Fix: unconnected direction input on ray portal bsdf is incorrect for OSL
17f2cdd104 Cycles: Add thin film iridescence to Principled BSDF
e8d028b7a5 Fix #121338: Depthdropper ensure viewport camera
725408e842 GPv3: Extrude operator
5b7a0ed1b5 Refactor: move keyingset enums to animrig
Compare 10 commits »
david494 created branch cycles-ray-portal-osl-fix in david494/blender 2024-05-02 14:44:44 +02:00
david494 pushed to cycles-portal-bsdf at david494/blender 2024-04-21 20:25:37 +02:00
36a0540af0 remove unneeded Normal input for ray portal
david494 pushed to cycles-portal-bsdf at david494/blender 2024-04-21 20:20:20 +02:00
c07b11cc51 fix formatting
david494 commented on pull request blender/blender#114386 2024-04-21 20:18:06 +02:00
Cycles: Add Portal BSDF

1e-9 is somewhat arbitrary, but my reasoning was that this is a squared distance. 1e-5 would still consider an offset of 0.001 the same point. I think a reasonable value here is dependent on scale.

david494 commented on pull request blender/blender#114386 2024-04-21 00:42:29 +02:00
Cycles: Add Portal BSDF

Thanks again, I now replaced all references to 'portal' with 'ray portal'.

david494 pushed to cycles-portal-bsdf at david494/blender 2024-04-21 00:34:19 +02:00
31bde20690 rename portal to ray portal
david494 commented on pull request blender/blender#114386 2024-04-08 02:54:49 +02:00
Cycles: Add Portal BSDF

Sorry, it took me a while to get back to this. Thanks for the review! All the code comments should be addressed.

Also, OSL support is currently missing. I don't see any issues with adding it…

david494 commented on pull request blender/blender#114386 2024-04-08 02:34:13 +02:00
Cycles: Add Portal BSDF

I agree, looks more readable.