david494
  • Joined on 2023-11-02
david494 opened issue blender/blender#130152 2024-11-11 18:53:59 +01:00
Geometry Nodes: Should Realize Instances Node flip normals if scale is negative?
david494 opened issue blender/blender#127054 2024-09-01 22:31:43 +02:00
Geometry Nodes: Crash while dragging value (Resample Curve node?)
david494 opened issue blender/blender#126450 2024-08-18 03:19:26 +02:00
Geometry Nodes: Crash in Sample UV Surface node
david494 commented on pull request blender/blender#126157 2024-08-14 21:44:54 +02:00
Fix #126354: Cycles: Calculate correct bounds for hair objects

I think your code is readable, I don't think it needs to be refactored more. Having to do so much more work, for something that is probably only an edge case that is unlikely to be hit on…

david494 pushed to cycles-hair-bvh-bbox-fix at david494/blender 2024-08-14 21:43:02 +02:00
dd7cb94582 multi-threaded bounds calculation (thanks Sergey!)
369cd15d4f Merge branch 'main' into cycles-hair-bvh-bbox-fix
27bc773c0b Cleanup: Formatting
e04707bf2a Cleanup: Sculpt: Remove last usage of PBVHVertRef visibility function
70a24258c6 Sculpt: Remove unused positions array copy with some deform modifiers
Compare 139 commits »
david494 commented on issue blender/blender#117706 2024-08-09 23:58:33 +02:00
Cycles SVM Stack full with relatively few nodes

The original file works for me in 4.2 and I believe a reason for that might be that this was fixed: #122739

@Zeastin You can try using booleans and integers again, those should be more usable…

david494 commented on pull request blender/blender#126157 2024-08-09 22:34:29 +02:00
Fix #126354: Cycles: Calculate correct bounds for hair objects

This fixes the second problem reported in #123634 (not the original issue). I am not sure whether this is the correct fix, it might be a performance regression, but I don't have good test scenes…

david494 commented on issue blender/blender#123634 2024-08-09 22:32:02 +02:00
Cycles 3D Curves missing some intersections using Metal

I am pretty sure that the curved variant is a different issue, and I have a proposed fix for it in #126157. I cannot reproduce the original problem, maybe something changed, fixing it by accident?

david494 created pull request blender/blender#126157 2024-08-09 22:29:51 +02:00
WIP: Fix: Cycles: Calculate correct bounds for hair objects
david494 created branch cycles-hair-bvh-bbox-fix in david494/blender 2024-08-09 22:28:28 +02:00
david494 pushed to cycles-hair-bvh-bbox-fix at david494/blender 2024-08-09 22:28:28 +02:00
93832ed9f6 Fix: Cycles: Calculate correct bounds for hair objects
0250596f5b Cleanup: Sculpt: Remove more unnecessary shape key flushing
72b5fd677b Cleanup: Sculpt: Use C++ Array for fake neighbor indices
a2e3abd2d0 Refactor: Sculpt: Fake neighbor data creation
68146fe479 Fix: Sculpt pose brush incorrectly accumulates translations
Compare 10 commits »
david494 commented on pull request blender/blender#125919 2024-08-07 12:24:57 +02:00
Fix #114940: Cycles: GGX roughness has abrupt cutoff

I updated the patch with the replacement. I also removed the clamping, but I am unsure whether we want to keep that anyways? I am leaning towards not having it if it is unnecessary, but should…

david494 pushed to cycles-microfacet-precision at david494/blender 2024-08-07 12:21:45 +02:00
2f8ae2bb67 Better fix for precision issues in beckmann bsdf_D
david494 commented on pull request blender/blender#125919 2024-08-07 10:26:57 +02:00
Fix #114940: Cycles: GGX roughness has abrupt cutoff

I had another look at the point where bsdf_D is called in bsdf_microfacet_sample: The cos_NH argument is calculated as dot(N, H) which I think should just be the same as local_H.z with…

david494 commented on pull request blender/blender#125919 2024-08-06 23:46:24 +02:00
Fix #114940: Cycles: GGX roughness has abrupt cutoff

Even with the improved precision of D_beckmann the errors did not disappear completely. Adding the proposed clamping does indeed help, I updated the patch to add that with a comment.

david494 pushed to cycles-microfacet-precision at david494/blender 2024-08-06 23:34:40 +02:00
a6ee74d7b1 Clamp roughness in bsdf_D for beckmann microfacets
08189e5d8e Merge branch 'main' into cycles-microfacet-precision
9ed7d38aac Cycles: Improve numerical precision of Beckmann distribution at low roughness
aca466b029 Cleanup: Sculpt: Remove now unused brush strength function
fa49d90897 Sculpt: Refactor image painting to use new brush API
Compare 51 commits »
david494 commented on pull request blender/blender#125919 2024-08-05 22:46:07 +02:00
Fix #114940: Cycles: GGX roughness has abrupt cutoff

Just did another quick test to confirm this actually helps: Setting BSDF_ROUGHNESS_SQ_THRESH to 1.1e-19 still produces good images, anything lower introduces artifacts. This makes sense, as we use…

david494 commented on pull request blender/blender#125919 2024-08-05 20:43:59 +02:00
Fix #114940: Cycles: GGX roughness has abrupt cutoff

As suggested by @weizhen in #125750.

I tested this on apple arm cpu+gpu with a couple of random scenes, playing with the roughness and ran the test suite, no obvious issues.

david494 created pull request blender/blender#125919 2024-08-05 20:38:52 +02:00
Fix #114940: Cycles: GGX roughness has abrupt cutoff
david494 created branch cycles-microfacet-precision in david494/blender 2024-08-05 20:36:58 +02:00