david494
0 Followers · 0 Following
  • Joined on 2023-11-02
Repositories
1
 Projects Public Activity Starred Repositories
david494 commented on pull request blender/blender#114386 2024-04-08 02:33:26 +02:00
Cycles: Add Portal BSDF

Yes, that is a little bit of unfortunate naming. I did not want to shadow the function parameter sc, but maybe that is fine as its immediately cast to pc and we can refer to pc everywhere…

david494 commented on pull request blender/blender#114386 2024-04-08 02:30:53 +02:00
Cycles: Add Portal BSDF

This is inside a check that already checks for either LABEL_PORTAL or LABEL_TRANSPARENT (so should not disable MIS on diffuse?), and based on my tests I believe we want to disable MIS for…

david494 commented on pull request blender/blender#114386 2024-04-08 02:25:04 +02:00
Cycles: Add Portal BSDF

This is indeed based on the transparent BSDF code. While adding OSL support I also kept it close to the transparent code, which made the OSL changes very simple: osl_closure_portal_bsdf_setup…

david494 commented on pull request blender/blender#114386 2024-04-08 02:20:05 +02:00
Cycles: Add Portal BSDF

Yes, that makes it slightly more obvious if either has to change in the future.

david494 commented on pull request blender/blender#114386 2024-04-08 02:19:12 +02:00
Cycles: Add Portal BSDF

I agree. Added, with a small comment.

david494 pushed to cycles-portal-bsdf at david494/blender 2024-04-08 02:18:56 +02:00
c47609c0b6 added bsdf_portal_eval, separate from bsdf_transparent_eval now
david494 pushed to cycles-portal-bsdf at david494/blender 2024-04-08 02:07:59 +02:00
a9ea876595 small refactors based on review
5a10b83714 add OSL support
dca52a8f24 Merge branch 'main' into cycles-portal-bsdf
2d5a83f294 UI: Show Maximize Area on Asset Browser Header Context Menu
727979c1a8 Fix #120366: Snap to Grid is affected by geometry occlusion
Compare 1710 commits »
david494 pushed to cycles-portal-bsdf at david494/blender 2024-02-21 13:06:08 +01:00
536a5d42b0 Merge branch 'main', fixing conflict with BKE_node.hh
31869d6857 Cleanup: ImBuf: remove various unused functions
11db0b9dad Fix #118524: Loopcut crashes when not near an edge
f6adf4b1c5 Extensions: support dropping file-paths
e6eecdf614 EEVEE-Next: Voronoi colors are pure emissive
Compare 683 commits »
david494 closed issue blender/blender#117652 2024-02-06 01:46:32 +01:00
Transparent Shadows setting of one material influences shadows of other materials
david494 commented on issue blender/blender#117652 2024-02-06 01:46:29 +01:00
Transparent Shadows setting of one material influences shadows of other materials

This should be fixed now by #117735.

Materials don't influence each other anymore and the "Transparent Shadows" checkbox does what it says, Transparent BSDFs are now not transparent to shadows…

david494 pushed to cycles-portal-bsdf at david494/blender 2024-02-05 23:57:07 +01:00
4e6a92ce3f Fix merge conflicts in MIS logic, still skipping MIS for portals
72d324bd81 Fix #117865: "Create Face Sets" operator crashes for multires
4797773604 Fix #117816: Import USD DistantLight as Blender Sun light
df8c85d3f9 Cleanup: UI Remove more unnecessary a1 and a2 parameters
3cf1c795ff Fix assertion when creating an override of a enum custom property.
Compare 266 commits »
david494 deleted branch object-info-name from david494/blender 2024-01-30 10:50:03 +01:00
david494 created pull request blender/blender#117655 2024-01-30 02:09:38 +01:00
Add a "Name" output to the Object Info Node.
david494 pushed to object-info-name at david494/blender 2024-01-30 02:02:35 +01:00
cef1457c95 Add a "Name" output to the Object Info Node.
961783c444 Cleanup: Move BKE_deform.h to C++
e72dae4949 Fix crash when calculating the RNA path failed for property buttons
73214e9b26 Extensions: change the manifest filename
61fb2b17c8 Cleanup: Use std::string for WM API function return values
Compare 7 commits »
david494 created branch object-info-name in david494/blender 2024-01-30 02:02:35 +01:00
david494 opened issue blender/blender#117652 2024-01-29 23:38:24 +01:00
Transparent Shadows setting of one material influences shadows of other materials
david494 commented on pull request blender/blender#114386 2024-01-29 23:21:56 +01:00
Cycles: Add Portal BSDF

I think I found an unrelated bug with transparent shadows during my tests: If there are any materials that contain transparent closures and have the "Transparent Shadows" checkbox set, all other…

david494 commented on pull request blender/blender#114386 2024-01-29 23:04:44 +01:00
Cycles: Add Portal BSDF

Yes, that one is a bit strange. I did not find a better place to disable transparent shadows for rays intersecting with portals, since I am reusing transparent_extinction, which is used in…

david494 commented on pull request blender/blender#114386 2024-01-29 22:38:37 +01:00
Cycles: Add Portal BSDF

That simplifies things nicely, I agree.

david494 commented on pull request blender/blender#114386 2024-01-29 22:37:46 +01:00
Cycles: Add Portal BSDF

Yep, thanks. Also reads better :)