Missed this the first time through but we should remove the raw printf. Can you add a CLOG here as follows:
Seems was missed? We had prior UI module feedback for removing the "When checked" type wording in these so just noting again.
For all these messages remove the "When checked" wording and just say "Export all foos" for each of them.
The export_materials item seems duplicated; is still present above this.
Ah, so the limit_precision
option is only used on the various matrix transform data for objects (including blend shape and armature transform matrices), not the actual vertex data. This is why…
Indeed, the Layout workspace is set to Local view. Will close as this is not a bug.
I'm not able to reproduce this on Windows at least. Attached are 2 files, both from the default scene, the first exported normally and the second with the "Limit Precision" option checked. There…
It is also fixed in 4.1
Are the "recommendations" consolidated somewhere? It would be helpful if they were so we could mention the scenario in our commit description etc.
That said it does look like there's some…
Can you move this inside do_write
and make it constexpr
instead of static const.
We've been standardizing on just checking root_prim_path[0] != '\0'
instead of doing a length check for most strings like this across blender.
Are these enums necessary? They're pretty much the same as eIOAxis
inside IO_orientation.hh
. Can also see how they're used in the other exporters.
Our other exporters don't bother with the "Global Up axis for export" type messages. It's probably ok to leave the descriptions blank here too.