extensions/add_camera_rigs
0
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

Fix the set_dof_bone operator. #2

Merged
Nika Kutsniashvili merged 1 commits from CypherPoet/add_camera_rigs:fix-set-dof-bone-2 into main 2024-09-19 15:12:20 +02:00
Conversation 2 Commits 1 Files Changed 1 +1 -1
CypherPoet commented 2024-09-18 07:10:55 +02:00
Contributor
Copy Link

This fixes the aim bone name that's targeted for 3D rigs during the set_dof_bone operator's execution.

I noticed it was out of sync with the name used when the bone is first built.

This fixes the aim bone name that's targeted for 3D rigs during the `set_dof_bone` operator's execution. I noticed it was out of sync with the [name used when the bone is first built](https://projects.blender.org/extensions/add_camera_rigs/src/commit/6d368c9a5399edc6f951f5581cebfbf5c9e9c824/source/build_rigs.py#L42).
CypherPoet added 1 commit 2024-09-18 07:10:56 +02:00 
This fixes the aim bone name that's targeted for 3D rigs during the `set_dof_bone` operator's execution.
CypherPoet changed title from Fix the set_dof_bone operator. to Fix the `set_dof_bone` operator. 2024-09-18 07:11:14 +02:00
Nika Kutsniashvili approved these changes 2024-09-19 15:12:03 +02:00
Nika Kutsniashvili left a comment
Owner
Copy Link

Thanks for the fix. In future if you make more contributions add me as a reviewer so PR is noticed

Thanks for the fix. In future if you make more contributions add me as a reviewer so PR is noticed
👍 1 ❤️ 1
Nika Kutsniashvili merged commit 219660a5f3 into main 2024-09-19 15:12:20 +02:00
CypherPoet deleted branch fix-set-dof-bone-2 2024-09-20 05:10:47 +02:00
CypherPoet commented 2024-09-26 12:19:26 +02:00
Author
Contributor
Copy Link

@nickberckley Will do. On a related note, what's the best way to have changes here reflected on https://extensions.blender.org/?

I noticed that while the version was bumped to 1.6.2 following these changes, the public extension is still at 1.6.1.

@nickberckley Will do. On a related note, what's the best way to have changes here reflected on https://extensions.blender.org/? I noticed that while the version was bumped to `1.6.2` following these changes, the [public extension](https://extensions.blender.org/add-ons/add-camera-rigs/) is still at `1.6.1`.
Nika Kutsniashvili commented 2024-09-26 12:29:00 +02:00
Owner
Copy Link

We'll update it. Person who knows how to batch-update is on vacation so I'm waiting for him. Should be in couple of days

We'll update it. Person who knows how to batch-update is on vacation so I'm waiting for him. Should be in couple of days
👍 1
Sign in to join this conversation.
Reviewers
No reviewers
Nika Kutsniashvili
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: extensions/add_camera_rigs#2
No description provided.
Delete Branch "CypherPoet/add_camera_rigs:fix-set-dof-bone-2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?