extensions/io_scene_x3d
1
1
Fork 4
Code Issues 12 Pull Requests 1 Projects Releases Wiki Activity

fix blender/blender-addons#105398 include case faces same color #1

Closed
Cedric Steiert wants to merge 1 commits from Bujus_Krachus/io_scene_x3d:fix-list-index-out-of-range into main
pull from: Bujus_Krachus/io_scene_x3d:fix-list-index-out-of-range
merge into: extensions:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 2 Commits 1 Files Changed 1 +4
Cedric Steiert commented 2024-07-19 20:24:52 +02:00
Collaborator
Copy Link

fixes blender/blender-addons#105398, where objects exported from solidworks get an list index out of range error, when all faces have the same color attributes. I've included it as a sperate case (when length of faces and rgb is different) because i currently don't know if the default case is actually valid and needed.

fixes blender/blender-addons#105398, where objects exported from solidworks get an list index out of range error, when all faces have the same color attributes. I've included it as a sperate case (when length of faces and rgb is different) because i currently don't know if the default case is actually valid and needed.
Cedric Steiert added 1 commit 2024-07-19 20:24:54 +02:00 
fixes blender/blender-addons#105398, where objects from solidworks get an list index out of range error, when all faces have the same color attributes.
Cedric Steiert changed title from fix https://projects.blender.org/blender/blender-addons/issues/105398 include case same color to fix blender/blender-addons/issues/105398 include case same color 2024-07-20 00:45:51 +02:00
Cedric Steiert changed title from fix blender/blender-addons/issues/105398 include case same color to fix blender/blender-addons/issues/105398 include case faces same color 2024-07-20 00:46:13 +02:00
Cedric Steiert commented 2024-07-21 13:58:33 +02:00
Author
Collaborator
Copy Link

Btw didn't test for different files yet, however as we target array length mismatch this probably shouldn't cause any issues

Btw didn't test for different files yet, however as we target array length mismatch this probably shouldn't cause any issues
Cedric Steiert changed title from fix blender/blender-addons/issues/105398 include case faces same color to fix blender/blender-addons#105398 include case faces same color 2024-07-22 03:30:04 +02:00
Campbell Barton approved these changes 2024-07-22 04:22:25 +02:00
Campbell Barton commented 2024-07-22 04:31:36 +02:00
Owner
Copy Link

Thanks, merged 792b2c5ce5.

Thanks, merged 792b2c5ce5c6159e55c5b91b1df35cdcda92fd71.
Campbell Barton closed this pull request 2024-07-22 04:31:37 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Campbell Barton
Labels
Clear labels   
bug

Something is not working

  
confirmed

The issue is confirmed.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
High

Priority high: This issue should be worked on soon, as it breaks things drastically

  
known issue

A known technical limitation. It may get fixed eventually, but no support expected.

  
Normal

Priority normal: Not a high issue, still relevant

  
not a task

just some content

  
question

More information is needed

  
task

Tasks that should be worked on

  
v2.4

Tasks included for 2.4 release

  
wontfix

This won't be fixed

No Label
bug
confirmed
duplicate
enhancement
help wanted
High
known issue
Normal
not a task
question
task
v2.4
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: extensions/io_scene_x3d#1
No description provided.
Delete Branch "Bujus_Krachus/io_scene_x3d:fix-list-index-out-of-range"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?