extensions/io_scene_x3d
2
1
Fork 4
Code Issues 14 Pull Requests 2 Projects Releases Wiki Activity

Define a poll class method for the class X3D_PT_import_general #33

Merged
Cedric Steiert merged 1 commits from vmarchetti/io_scene_x3d:repair-export-panel into main 2024-10-29 03:17:39 +01:00
Conversation 0 Commits 1 Files Changed 1 +8
Vincent Marchetti commented 2024-10-29 03:03:42 +01:00
Collaborator
Copy Link

Since commit 6f83502ad5 the following message is printed to console when an Export to X3D is invoked from the menu

rna_uiItemR: property not found: EXPORT_SCENE_OT_x3d.as_collection

This message is correlated with the addition of the class X3D_PT_import_general at commit 6f83502ad5 that is missing the class method poll.

This pull request adds a boilerplate definition of the poll method to the X3D_PT_import_general . As a result, the warning message is no longer printed upon an X3D export invocation.

This may be demonstrated by starting blender with the default cube model, and invoking the export X3D from the menu. The warning messages are printed to console before the user selects the output path for the export.

Since commit 6f83502ad5 the following message is printed to console when an Export to X3D is invoked from the menu `rna_uiItemR: property not found: EXPORT_SCENE_OT_x3d.as_collection` This message is correlated with the addition of the class X3D_PT_import_general at commit 6f83502ad5 that is missing the class method poll. This pull request adds a boilerplate definition of the poll method to the X3D_PT_import_general . As a result, the warning message is no longer printed upon an X3D export invocation. This may be demonstrated by starting blender with the default cube model, and invoking the export X3D from the menu. The warning messages are printed to console before the user selects the output path for the export.
Vincent Marchetti added 1 commit 2024-10-29 03:03:44 +01:00
Vincent Marchetti requested review from Cedric Steiert 2024-10-29 03:05:50 +01:00
Cedric Steiert approved these changes 2024-10-29 03:17:22 +01:00
Cedric Steiert left a comment
Collaborator
Copy Link

Thanks for checking and fixing, seems like i totally missed to inlcude the poll method back then...

Thanks for checking and fixing, seems like i totally missed to inlcude the poll method back then...
Cedric Steiert merged commit d06e6d8afd into main 2024-10-29 03:17:39 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Cedric Steiert
Labels
Clear labels   
bug

Something is not working

  
confirmed

The issue is confirmed.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
High

Priority high: This issue should be worked on soon, as it breaks things drastically

  
known issue

A known technical limitation. It may get fixed eventually, but no support expected.

  
Low

Priority low: Could be worked on, but is of no need

  
Normal

Priority normal: Not a high issue, still relevant

  
not a task

just some content

  
question

More information is needed

  
task

Tasks that should be worked on

  
v2.4

Tasks included for 2.4 release

  
wontfix

This won't be fixed

No Label
bug
confirmed
duplicate
enhancement
help wanted
High
known issue
Low
Normal
not a task
question
task
v2.4
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: extensions/io_scene_x3d#33
No description provided.
Delete Branch "vmarchetti/io_scene_x3d:repair-export-panel"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?