fix wrl files with pixel image textures not importing correctly #4

Merged
Cedric Steiert merged 2 commits from Bujus_Krachus/io_scene_x3d:fix-wrl-import-image-texture into main 2024-08-06 17:23:53 +02:00
Collaborator

this fix for blender/blender-addons#85269 contains three parts for wrl pixel image textures:

  • use newer api specification, like suggested in a comment on the issue
  • read hex color values across multiple lines/fields, instead of trusting int values being present in single line (the file from issue had hex values, multiline instead of int values singleline)
  • ignoring pixel image textures with no pixel data (idk why these would even exist, but the attached file had those)
    Now the file from the issue imports and displays correctly.
this fix for https://projects.blender.org/blender/blender-addons/issues/85269 contains three parts for wrl pixel image textures: - use newer api specification, like suggested in a comment on the issue - read hex color values across multiple lines/fields, instead of trusting int values being present in single line (the file from issue had hex values, multiline instead of int values singleline) - ignoring pixel image textures with no pixel data (idk why these would even exist, but the attached file had those) Now the file from the issue imports and displays correctly.
Cedric Steiert added 1 commit 2024-07-20 03:22:33 +02:00
this fix for blender/blender-addons#85269 contains three parts for wrl pixel image textures:
- use newer api specification, like suggested in a comment on the issue
- read hex color values across multiple lines/fields, instead of trusting int values being present in single line (the file from issue had hex values, multiline instead of int values singleline)
- ignoring pixel image textures with no pixel data (idk why these would even exist, but the attached file had those)
Now the file from the issue imports and displays correctly.
Collaborator

Works fine with my VRML files, thanks 👍

Works fine with my VRML files, thanks 👍
Cedric Steiert added 1 commit 2024-08-06 17:23:19 +02:00
Cedric Steiert merged commit a33ad05f5d into main 2024-08-06 17:23:53 +02:00
Cedric Steiert deleted branch fix-wrl-import-image-texture 2024-08-06 17:23:54 +02:00
Sign in to join this conversation.
No description provided.