I'll remove the WIP in the next push
wow that's a fast review 😅
But I think those should be subject of a separated PR, this one is better to keep it short and small about fixing the infinite loop.
Or better yet, either
-
Multires completely ignores hidden face state and process every face as visible, (because creating random N-gons will mess up the modeling pipeline later)
-
or…
@farsthary Did you check if it's due to the unintiialized
corner_x/corner_yafter the callmultires_unsubdivide_get_grid_corners_on_base_mesh()?
With your proposed changes, removing…
@Sergey I can 100% repro the Debug build crash with this file. Steps: 1-compile blender Debug 2-open the file and press unsubdivide
Xcode will trigger a break at
@HooglyBoogly without the second null check it crashes on Debug only (on Release the BLI_abort() seems to be successfully ignored but still is a crash) Adding the null check run successfully in…
I know it can return null, but there is a null check on the next iteration of the while loop that covers this. Unless I'm really missing something, It just seems wrong/weird to check for null on…
The description was a bit confusing because the block of code isn't the previous state, it's the new state in the PR.
But the fix makes sense. To make things clear though, maybe it's best…