Raul Fernandez Hernandez farsthary
  • Joined on 2008-06-18
Raul Fernandez Hernandez commented on pull request blender/blender#120125 2024-04-13 02:07:08 +02:00
Sculpt: Improve Expand performance

Nice tip thanks!

Raul Fernandez Hernandez commented on pull request blender/blender#120125 2024-04-13 00:59:54 +02:00
Sculpt: Improve Expand performance

If we have in Blender a lock free and wait free performant Hash table I could substitute for it. I suggest reviewers to actually compile and test the branch to clear any doubt of its correctness.…

Raul Fernandez Hernandez commented on pull request blender/blender#120125 2024-04-12 22:52:29 +02:00
Sculpt: Improve Expand performance

hence are not a suitable recommendation. I've refactored that part in a separate function so everyone should be happy now ;)

Raul Fernandez Hernandez pushed to improve-expand-perf at farsthary/blender 2024-04-12 22:42:48 +02:00
b9f6ccf007 feedback
Raul Fernandez Hernandez commented on pull request blender/blender#120125 2024-04-12 22:23:09 +02:00
Sculpt: Improve Expand performance

Just tried using VectorSet and Set for this and it didn't worked. It crashes Blender.

Raul Fernandez Hernandez pushed to improve-expand-perf at farsthary/blender 2024-04-12 22:00:42 +02:00
952c832894 nit pick
Raul Fernandez Hernandez pushed to improve-expand-perf at farsthary/blender 2024-04-12 19:56:46 +02:00
1da76ddb7b nit pick
Raul Fernandez Hernandez commented on pull request blender/blender#120125 2024-04-12 18:26:33 +02:00
Sculpt: Improve Expand performance

The main reason on using a preallocated vector/array is to allow independent writes to each bucket in a performant way. Do blender set allows preallocation and independent writes?

Raul Fernandez Hernandez commented on pull request blender/blender#120125 2024-04-12 17:58:35 +02:00
Sculpt: Improve Expand performance

this will add unnecessary verbosity in a context where is clear what v1 and v2 means

Raul Fernandez Hernandez commented on pull request blender/blender#120125 2024-04-12 17:46:24 +02:00
Sculpt: Improve Expand performance

For this technique I use a dual advancing front which a Set/Hash table does not quite map correctly. Is the core of this PR

Raul Fernandez Hernandez pushed to main at farsthary/blender 2024-04-12 17:18:51 +02:00
d5f837a8ee Cleanup: remove redundant string formatting
0660fa6971 UI: remove double-quoting in report
52cff75ce0 Geometry Nodes: Avoid repeated node tools lookup when empty
Compare 3 commits »
Raul Fernandez Hernandez pushed to improve-expand-perf at farsthary/blender 2024-04-12 17:01:01 +02:00
Raul Fernandez Hernandez commented on pull request blender/blender#120125 2024-04-12 16:40:13 +02:00
Sculpt: Improve Expand performance

This will negate the performance gain, Blender set is really slow and this technique works really well, I've spent several days testing and refining it.

Raul Fernandez Hernandez commented on pull request blender/blender#120125 2024-04-12 03:09:29 +02:00
Sculpt: Improve Expand performance

Applied

Raul Fernandez Hernandez pushed to improve-expand-perf at farsthary/blender 2024-04-12 02:28:04 +02:00
16bd4e7eef reset tests
Raul Fernandez Hernandez pushed to improve-expand-perf at farsthary/blender 2024-04-12 01:16:04 +02:00
820a331a66 Revert "Cleanup: use const EnumPropertyItem pointers"
f27c985acd Revert "Cleanup: pass const arrays for default boolean arguments"
efc088aa94 Revert "Cleanup: remove redundant checks & struct declaration"
5b1f4ae917 Revert "Cleanup: pass const arguments in freestyle functions"
3b7d7c6581 Revert "Cleanup: spelling in comments"
Compare 68 commits »
Raul Fernandez Hernandez pushed to main at farsthary/blender 2024-04-11 23:11:45 +02:00
ed8a97131f Fix: Typo in asset report message
f7d5ec8661 Refactor: Remove trim variables from SculptSession
8b9743eb40 CMake: Change build flags to use SSE42 if available
0bd6279504 Nodes: Display node label for tooltips on a free reroute
248dafef74 Geometry Nodes: use rotation socket in Curve to Points node
Compare 67 commits »
Raul Fernandez Hernandez commented on pull request blender/blender#120125 2024-04-11 22:02:40 +02:00
Sculpt: Improve Expand performance

If geometry nodes will let to view randomly selected vertices (by using index of vertex), shouldn't this cause vertex flickering?

I don't think so, this is an initialization step that happens…

Raul Fernandez Hernandez pushed to improve-expand-perf at farsthary/blender 2024-04-11 22:00:19 +02:00
a8d16ef143 feedback
8bda7c9036 UI: Indicate type of search in keymap search button
ff496fcc11 Fix #113182: Crash when animating Viewport visibility of Curves / GPv3 object
c1534f6f18 BLI: Fix inverted 0 determinant for infinite orthographic projection
9890e738a9 Fix #120417: VSE crash rendering a scene strip with missing Editing data
Compare 69 commits »
Raul Fernandez Hernandez commented on pull request blender/blender#120125 2024-04-11 18:53:39 +02:00
Sculpt: Improve Expand performance

I don't know how that file got changed, maybe a merge from main?