Raul Fernandez Hernandez farsthary
6 Followers · 1 Following
  • Joined on 2008-06-18
Repositories
4
 Projects Public Activity Starred Repositories
3
Raul Fernandez Hernandez commented on pull request blender/blender#119443 2024-03-14 16:17:54 +01:00
Fix #87243: Crash after undo "Mask slice to new object"

Moreover saving the sculpt undo state seems not necessary in this function since undo/redo works anyways.

It does not seem to be working: the mask attribute seems to be lost, and the…

Raul Fernandez Hernandez closed pull request blender/blender#119401 2024-03-13 21:27:36 +01:00
WIP: Fix #87243: Crash after undo "Mask slice to new object"
Raul Fernandez Hernandez commented on pull request blender/blender#119401 2024-03-13 21:27:34 +01:00
WIP: Fix #87243: Crash after undo "Mask slice to new object"

Closing this since I made a new PR that supersedes this one:

blender/blender#119443

Raul Fernandez Hernandez created pull request blender/blender#119443 2024-03-13 21:25:58 +01:00
Fix #87243: Crash after undo "Mask slice to new object"
Raul Fernandez Hernandez pushed to mask-slice-fix at farsthary/blender 2024-03-13 21:22:54 +01:00
c335802c53 nit
Raul Fernandez Hernandez commented on pull request blender/blender#119401 2024-03-13 21:19:04 +01:00
WIP: Fix #87243: Crash after undo "Mask slice to new object"

Why do you think is noise? , it simplifies the calling and gets reused in the 2 calls later, making them shorter so the formatted does not have to split the function into several lines.

Raul Fernandez Hernandez pushed to mask-slice-fix at farsthary/blender 2024-03-13 21:02:06 +01:00
f20e48c814 fix
Raul Fernandez Hernandez created branch mask-slice-fix in farsthary/blender 2024-03-13 21:02:06 +01:00
Raul Fernandez Hernandez pushed to main at farsthary/blender 2024-03-13 20:51:03 +01:00
023c1c7738 Merge branch 'blender-v4.1-release'
d562a9ce43 Fix #118883: Face Corner component shows in Delete Geometry node
b5082f6640 Refactor: Simplify BLI_serialize.hh for asset indexer
ae12c1bd92 Refactor: Remove unnecessary indirection from classes in asset indexer
24c9f736ff Cleanup: Follow style guide for use of "this" in classes
Compare 43 commits »
b364743edf minimize changes
81ea4d158b nit pick
Raul Fernandez Hernandez commented on pull request blender/blender#119401 2024-03-13 16:51:14 +01:00
WIP: Fix #87243: Crash after undo "Mask slice to new object"

Thanks for the reviews and feedback. @Sergey it was probably a branch from main or a merge with release-4.1 that went sideways, for that I will cherry-pick the changes from this PR to a new…

Raul Fernandez Hernandez created pull request blender/blender#119401 2024-03-13 00:02:05 +01:00
Fix 87243 Crash after undo "Mask slice to new object"
0ef6e0f039 Merge branch 'blender-v4.1-release' into Fix-87243-Crash-after-undo-Mask-slice-to-new-object
6b81fbced8 Cleanup: Make format
885b116c75 Fix: Socket names in auto smooth versioning node group
9141a8cb25 Fix #119398: Weighted normal modifier "Keep Sharp" option missing versioning
b7b7d3a937 Fix #119396: Add toggle for texture paint mask icon
Compare 33 commits »
020a3322f2 cleanup
0745a71532 Fix #119396: Add toggle for texture paint mask icon
022c5d58bf Fix #119307: Anchored multires mask brush broken
3d38e04185 Fix: Slider not respecting bounds when snapping to increments
f47e736215 Fix #119350: shifting text overlay text
bdd967ba81 Fix: update comparator for std::sort for NamedAttribute
Compare 29 commits »
Raul Fernandez Hernandez pushed to main at farsthary/blender 2024-03-12 22:04:51 +01:00
23a74f4d49 Merge branch 'blender-v4.1-release'
b7b7d3a937 Fix #119396: Add toggle for texture paint mask icon
51c738da1b Cleanup: Mesh: Use updated "corner" name for variables
9cafccf004 Cleanup: Sculpt: Unify face PBVH node face index access
b91d0aa0b8 Cleanup: Sculpt: Remove useless comments
Compare 100 commits »
3004997dae workaround for crash
Raul Fernandez Hernandez pushed to main at farsthary/.profile 2024-03-11 17:11:39 +01:00
b41586ac1f update
4d0936c7d7 Fix #119316: instancing lamps does not work
8b9abd09c8 Fix #119270: Multires color attribute fallback drawing changed to black
95810eec8f Fix #106235: use first non-dangling link of multi-input socket for internal link
c388ed1e53 Fix #118709: Crash in OIDN GPU detection for unsupported HIP device
972087ed58 Fix: Linux libraries have files stored as LFS that shouldn't be
Compare 31 commits »