So I am investigating this and there is one source of light leaking that seems to be the large light + shadow tracing. Setting shadow ray to 1 and steps to 1 fixes the leak.
However I am yet to…
The same could be done with /FI msvc and -include gcc where the behaviour is explicitly wanted, rather than a side effect you're exploiting.
What about clang?
I am not sure about hiding…
But now I'm drowned in compilation errors. 😫
Please attach them here so I can have a look.
I tested on Linux + AMD and on Mac M1 Ultra. Seems to be ok. I did experience a black viewport once for 1 frame (which might just be some other issue) but I can't reproduce anymore.
Interesting. So I guess we should add a hint inside this new WITH_GPU_SHADER_CPP_COMPILATION
that its only compatible with Ninja on windows.
I've tried defining it with target_compile_definitions but it didn't do the trick.
Does CMAKE config has the CMAKE_EXPORT_COMPILE_COMMAND
enables and does the C++ extension picks it…
I confirm it fixes the issue for me.