Clément Foucault fclem
29 Followers · 0 Following

  • I'm pixel pusher.

  • Joined on 2014-07-09
Repositories
3
 Projects Public Activity Starred Repositories
Clément Foucault commented on pull request blender/blender#109294 2023-06-23 17:52:43 +02:00
Workbench Next: Sculpt Support

Use functional cast for all eCustomDataType.

Clément Foucault commented on pull request blender/blender#109294 2023-06-23 17:52:43 +02:00
Workbench Next: Sculpt Support

The feature masking here is not obvious nor safe (bool could be different from 0/1). Prefer defining bool use_wire = features & SCULPT_BATCH_WIREFRAME != 0 and use as sculpt_batches_get_ex argument.

Clément Foucault commented on pull request blender/blender#109294 2023-06-23 17:52:43 +02:00
Workbench Next: Sculpt Support

Use functional cast for all eCustomDataType.

Clément Foucault commented on pull request blender/blender#109294 2023-06-23 17:52:42 +02:00
Workbench Next: Sculpt Support

Avoid contraction. SCULPT_BATCH_FACE_SET.

Clément Foucault pushed to main at blender/blender 2023-06-23 08:39:54 +02:00
ddd88c00b4 EEVEE-Next: Irradiance Cache: Initial Implementation
Clément Foucault deleted branch eevee-next-irradiance-cache from fclem/blender 2023-06-23 08:39:54 +02:00
Clément Foucault merged pull request blender/blender#108639 2023-06-23 08:39:53 +02:00
EEVEE-Next: Irradiance Cache: Initial Implementation
Clément Foucault pushed to eevee-next-irradiance-cache at fclem/blender 2023-06-23 08:31:21 +02:00
d370e3ef4b Merge branch 'main' into eevee-next-irradiance-cache
cd08a55a68 Fix compiler error caused by 9383d06688
9383d06688 Fix measure tool snapping to perpendicular while not dragging
f1fa2ecbf5 Fix 'Set Snap Base' not working with 'Face Project' or 'Face Nearest'
eeecc24014 Cleanup: BLI: Deduplicate bounds merging
Compare 11 commits »
Clément Foucault pushed to eevee-next-irradiance-cache at fclem/blender 2023-06-23 00:01:15 +02:00
e612b16a4f Fix cast style
cdcd3b4b60 Address review
Compare 2 commits »
Clément Foucault commented on issue blender/blender#108901 2023-06-22 23:50:10 +02:00
Points not rendered when indices are higher than 67.5 million(roughly)

I think this has to do with this snippet:

int pointcloud_get_point_id()
{
  return gl_VertexID / 32;
}

Basically, I reserve some bits inside the index buffer to store the point…

Clément Foucault commented on pull request blender/blender#108639 2023-06-22 22:59:03 +02:00
EEVEE-Next: Irradiance Cache: Initial Implementation

@blender-bot build linux

Clément Foucault pushed to eevee-next-irradiance-cache at fclem/blender 2023-06-22 22:57:08 +02:00
87bd956ea1 Merge branch 'main' into eevee-next-irradiance-cache
8d2d2d4620 GPU: Math: Add safe_rcp and safe_normalize to math libs
01e3b3c84a Fix NaN in the Spherical Harmonic evaluation
8924f86930 Attempt to fix linking issue on linux
b1f7c87b99 Cleanup: Use const for UI coordinate conversion functions
Compare 24 commits »
Clément Foucault pushed to main at blender/blender 2023-06-22 22:51:29 +02:00
8d2d2d4620 GPU: Math: Add safe_rcp and safe_normalize to math libs
Clément Foucault commented on pull request blender/blender#108639 2023-06-22 18:38:54 +02:00
EEVEE-Next: Irradiance Cache: Initial Implementation

@blender-bot build linux

Clément Foucault pushed to eevee-next-irradiance-cache at fclem/blender 2023-06-22 18:38:32 +02:00
d0a456db2d Address Review
7ac93775b0 Add eevee_lightcache.hh to CMakeLists.txt
Compare 2 commits »
Clément Foucault commented on pull request blender/blender#108639 2023-06-22 18:30:39 +02:00
EEVEE-Next: Irradiance Cache: Initial Implementation

I'm not sure about what you are suggesting. EEVEE_NEXT_LightBake is never defined and is just here to hide eevee::LightBake. Are you suggesting `using EEVEE_NEXT_LightBake = struct EEVEE_NEXT_L…

Clément Foucault commented on pull request blender/blender#108639 2023-06-22 12:06:21 +02:00
EEVEE-Next: Irradiance Cache: Initial Implementation

@blender-bot build

Clément Foucault pushed to eevee-next-irradiance-cache at fclem/blender 2023-06-22 12:05:50 +02:00
becf326283 Fix naming convention
e8943b3831 Fix clang-format issues
08df95c35c Merge branch 'main' into eevee-next-irradiance-cache
16e187778b Fix compiler warnings
b3f3b41d09 GPv3: Initial Layer Tree UI
Compare 67 commits »
Clément Foucault commented on pull request blender/blender#108639 2023-06-22 12:04:47 +02:00
EEVEE-Next: Irradiance Cache: Initial Implementation

It is already guarded in LightBake class.

Clément Foucault commented on pull request blender/blender#108639 2023-06-22 12:04:27 +02:00
EEVEE-Next: Irradiance Cache: Initial Implementation

It is already guarded in LightBake class.