Clément Foucault fclem
29 Followers · 0 Following

  • I'm pixel pusher.

  • Joined on 2014-07-09
Repositories
3
 Projects Public Activity Starred Repositories
Clément Foucault suggested changes for blender/blender#105521 2023-03-07 15:16:35 +01:00
GPU: Refactor API for Clearing Storage Buffers
Clément Foucault commented on pull request blender/blender#105521 2023-03-07 15:16:35 +01:00
GPU: Refactor API for Clearing Storage Buffers

There is no reason to clear_data_len a uint8_t. Just make it a int type.

Clément Foucault approved blender/blender#105528 2023-03-07 15:03:30 +01:00
Cleanup: Use CPP Wrapper to Clear SSBO in Eevee-next.
Clément Foucault approved blender/blender#105236 2023-03-07 14:51:44 +01:00
Viewport: draw light icons using the light colors

Talked IRL to Andy about the pros and cons of each approach.

Clément Foucault commented on pull request blender/blender#104580 2023-03-06 18:52:14 +01:00
EEVEE Next: Tag shadowmap usage for transparent object volumes

Not quite. lP here is shading point relative to the shadow origin in light space. light._position isn't the actual position of the light in world space but the offset in light space to the…

Clément Foucault commented on issue blender/blender#105492 2023-03-06 18:36:53 +01:00
GPU: New API for clearing SSBOs

LGTM!

Clément Foucault suggested changes for blender/blender#105423 2023-03-06 18:34:28 +01:00
Refactor: GLSL: Cleanup Clip Space vs. NDC Space naming
Clément Foucault commented on pull request blender/blender#105423 2023-03-06 18:34:28 +01:00
Refactor: GLSL: Cleanup Clip Space vs. NDC Space naming

You still need to fix the merge errors. This will not compile as point_view_to_ndc does not exist anymore.

Clément Foucault commented on pull request blender/blender#105423 2023-03-06 18:34:28 +01:00
Refactor: GLSL: Cleanup Clip Space vs. NDC Space naming

Same thing here.

Clément Foucault commented on pull request blender/blender#104687 2023-03-06 09:30:33 +01:00
Metal: Resolve race condition when releasing large numbers of buffers simultaneously.

#105254 replace this PR. Closing.

Clément Foucault closed pull request blender/blender#104687 2023-03-06 09:30:33 +01:00
Metal: Resolve race condition when releasing large numbers of buffers simultaneously.
Clément Foucault pushed to main at blender/blender 2023-03-05 18:14:50 +01:00
b4d36b3efe GPU: Compute: Document and cleanup header
Clément Foucault pushed to main at blender/blender 2023-03-05 17:57:59 +01:00
4862d56a0e GPUFrameBuffer: Document and cleanup header
d782569682 Cleanup: GPU: Improve eGPUBarrier documentation
0a10571501 GPU: Replace GPU_finish by correct memory barrier
Compare 3 commits »
Clément Foucault commented on pull request blender/blender#105423 2023-03-04 21:08:03 +01:00
Refactor: GLSL: Cleanup Clip Space vs. NDC Space naming

Here

Clément Foucault commented on pull request blender/blender#105423 2023-03-04 21:08:03 +01:00
Refactor: GLSL: Cleanup Clip Space vs. NDC Space naming

Here.

Clément Foucault suggested changes for blender/blender#105423 2023-03-04 21:08:03 +01:00
Refactor: GLSL: Cleanup Clip Space vs. NDC Space naming

The PR still contain the conflicts. You need to manually edit these to keep both changes. Also try to build with WITH_GPU_SHADER_BUILDER (see this and this).

Clément Foucault commented on pull request blender/blender#105423 2023-03-04 18:52:41 +01:00
Refactor: GLSL: Cleanup Clip Space vs. NDC Space naming

The patch looks good. But there are some merge conflicts on two files. You need to merge main to your branch git merge main and then push your updates.

Clément Foucault approved blender/blender#105423 2023-03-04 18:48:52 +01:00
Refactor: GLSL: Cleanup Clip Space vs. NDC Space naming
Clément Foucault pushed to main at blender/blender 2023-03-04 07:44:49 +01:00
f5e9a78216 GPU: Fix wrong barrier in tests
fcedc97d11 GPU: Add GPU_BARRIER_BUFFER_UPDATE barrier type
Compare 2 commits »
Clément Foucault suggested changes for blender/blender#105423 2023-03-04 07:03:03 +01:00
Refactor: GLSL: Cleanup Clip Space vs. NDC Space naming

Thanks for tackling this task! Seems all good.